Paths

Table of Contentst

Parse the output of `svnlook diff ...`
ClosedPublic
Actions

Authored by epriestley on Dec 18 2013, 9:06 PM.

Tags

None

Referenced Files

	F15410704: D7790.id17631.diff
	Wed, Mar 19, 8:13 AM

	F15399349: D7790.diff
	Mon, Mar 17, 4:06 AM

	F15395222: D7790.id17623.diff
	Sun, Mar 16, 3:53 AM

	F15393690: D7790.diff
	Sat, Mar 15, 11:02 PM

	F15391050: D7790.id.diff
	Sat, Mar 15, 7:59 AM

	F15387143: D7790.id.diff
	Sat, Mar 15, 1:54 AM

	F15385140: D7790.diff
	Fri, Mar 14, 9:49 PM

	F15283176: D7790.id.diff
	Tue, Mar 4, 5:48 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4195: Implement pre-commit Herald rules

Commits

rARC8e177c4db8d1: Parse the output of `svnlook diff ...`

Summary

Ref T4195. When figuring out changed content in SVN, the easiest approach is to use svnlook diff, but it has a slightly different header than we're used to. Adjust the parser for it and add some tests.

Test Plan

Clean unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 18 2013, 10:10 PM

Closed by commit rARC8e177c4db8d1 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

ArcanistDiffParser.php

5 lines

__tests__/

ArcanistDiffParserTestCase.php

5 lines

diff/

svnlook-add.svndiff

7 lines

svnlook-basics.svndiff

10 lines

svnlook-delete.svndiff

7 lines

Diff 17631

View Options

src/parser/ArcanistDiffParser.php

View Options

src/parser/tests/ArcanistDiffParserTestCase.php

View Options

src/parser/tests/diff/svnlook-add.svndiff

View Options

src/parser/tests/diff/svnlook-basics.svndiff

View Options

src/parser/tests/diff/svnlook-delete.svndiff

Parse the output of `svnlook diff ...`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17631

src/parser/ArcanistDiffParser.php

src/parser/__tests__/ArcanistDiffParserTestCase.php

src/parser/__tests__/diff/svnlook-add.svndiff

src/parser/__tests__/diff/svnlook-basics.svndiff

src/parser/__tests__/diff/svnlook-delete.svndiff

Parse the output of `svnlook diff ...`
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/tests/ArcanistDiffParserTestCase.php

src/parser/tests/diff/svnlook-add.svndiff

src/parser/tests/diff/svnlook-basics.svndiff

src/parser/tests/diff/svnlook-delete.svndiff