Page MenuHomePhabricator

Provide convenience method addTextCrumb() to PhabricatorCrumbsView
ClosedPublic

Authored by epriestley on Dec 18 2013, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 1, 12:22 PM
Unknown Object (File)
Sat, May 31, 2:14 PM
Unknown Object (File)
Sat, May 31, 3:17 AM
Unknown Object (File)
Fri, May 30, 8:08 PM
Unknown Object (File)
Fri, May 30, 5:30 PM
Unknown Object (File)
Fri, May 30, 4:25 PM
Unknown Object (File)
Thu, May 29, 1:11 PM
Unknown Object (File)
Tue, May 6, 4:33 AM
Subscribers

Details

Summary

We currently have a lot of calls to addCrumb(id(new PhabricatorCrumbView())->...) which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan
  • This was mostly automated, then I cleaned up a few unusual sites manually.
  • Bunch of grep / randomly clicking around.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped