Page MenuHomePhabricator

Provide convenience method addTextCrumb() to PhabricatorCrumbsView
ClosedPublic

Authored by epriestley on Dec 18 2013, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 7:43 PM
Unknown Object (File)
Wed, May 1, 6:45 PM
Unknown Object (File)
Thu, Apr 25, 12:07 AM
Unknown Object (File)
Thu, Apr 18, 5:37 PM
Unknown Object (File)
Mon, Apr 8, 3:36 AM
Unknown Object (File)
Fri, Apr 5, 9:07 PM
Unknown Object (File)
Fri, Apr 5, 7:29 AM
Unknown Object (File)
Mar 17 2024, 8:56 PM
Subscribers

Details

Summary

We currently have a lot of calls to addCrumb(id(new PhabricatorCrumbView())->...) which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan
  • This was mostly automated, then I cleaned up a few unusual sites manually.
  • Bunch of grep / randomly clicking around.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped