Differential D7783
Truncate object fields in Herald transcripts Authored by epriestley on Dec 18 2013, 12:35 AM. Tags None Referenced Files
Details
A few users have hit cases where Herald transcripts of large commits exceed the MySQL packet limit, because one of the fields in the transcript is an enomrous textual diff. There's no value in saving these huge amounts of data. Transcripts are useful for understanding the action of Herald rules, but can be reconstructed later. Instead of saving all of the data, limit each field to 4KB of data. For strings, we just truncate at 4KB. For arrays, we truncate after 4KB of values. Ran unit tests. Artificially decreased limit and ran transcripts, saw them truncate properly.
Diff Detail
Event TimelineComment Actions In PHP, we get to write our own unicode support! phutil_utf8_shorten() is just particularly bad for this sort of thing since it shortens to a display length, not a byte length. The resulting string may contain an arbitrarily large number of bytes, e.g. a single "e" followed by a billion combining characters. The function is appropriate when shortening text for inclusion in tables/buttons/UI elements, but not for truncating text. We should write some phutil_utf8_truncate() which shortens to a byte length or something and has something closer to O(1) runtime (see T3307) but haven't gotten around to it yet, since most of the shortening we do cares about display length. |