Add `rulePHID` to HeraldEffect
ClosedPublic
Actions

Authored by epriestley on Dec 17 2013, 8:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 27, 7:41 AM

	Unknown Object (File)
	Fri, Dec 27, 1:38 AM

	Unknown Object (File)
	Fri, Dec 20, 10:43 PM

	Unknown Object (File)
	Tue, Dec 17, 8:24 PM

	Unknown Object (File)
	Sun, Dec 15, 7:49 PM

	Unknown Object (File)
	Sat, Dec 14, 6:20 AM

	Unknown Object (File)
	Thu, Dec 12, 6:20 PM

	Unknown Object (File)
	Tue, Dec 10, 1:31 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4195: Implement pre-commit Herald rules

Commits

Restricted Diffusion Commit
rPbaa756a027fa: Add `rulePHID` to HeraldEffect

Summary

Ref T4195. Herald rules gained PHIDs only recently, propagate them to HeraldEffect to make some of the hook stuff eaiser.

Test Plan

iiam

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 17 2013, 9:20 PM

Closed by commit rPbaa756a027fa (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

engine/

HeraldEffect.php

22 lines

HeraldEngine.php

1 line

Diff 17607

View Options

src/applications/herald/engine/HeraldEffect.php