Fix fatal in Git hook when a --force push completely rewrites a ref
ClosedPublic
Actions

Authored by epriestley on Dec 11 2013, 8:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 2:03 PM

	Unknown Object (File)
	Tue, Dec 24, 3:57 PM

	Unknown Object (File)
	Thu, Dec 19, 11:03 AM

	Unknown Object (File)
	Thu, Dec 19, 3:48 AM

	Unknown Object (File)
	Fri, Dec 13, 8:01 PM

	Unknown Object (File)
	Thu, Dec 12, 11:36 PM

	Unknown Object (File)
	Thu, Dec 12, 3:39 AM

	Unknown Object (File)
	Dec 8 2024, 9:57 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4224: Failure when trying to force push

Commits

Restricted Diffusion Commit
rP61c934449d17: Fix fatal in Git hook when a --force push completely rewrites a ref

Summary

Fixes T4224. If you git merge-base A B, and they have no ancestor, the command exits with an error. Assume errors mean "no ancestry" and continue.

Test Plan

Completely rewrite a repository with a --force push.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 11 2013, 10:33 PM

Closed by commit rP61c934449d17 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

15 lines

Diff 17546

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix fatal in Git hook when a --force push completely rewrites a refClosedPublicActions