Fix fatal in Git hook when a --force push completely rewrites a ref
ClosedPublic
Actions

Authored by epriestley on Dec 11 2013, 8:31 PM.

Tags

None

Referenced Files

	F15490327: D7756.id17546.diff
	Fri, Apr 11, 4:11 PM

	F15487590: D7756.id.diff
	Thu, Apr 10, 3:17 PM

	F15485898: D7756.diff
	Thu, Apr 10, 3:23 AM

	F15485169: D7756.diff
	Wed, Apr 9, 10:17 PM

	F15464745: D7756.diff
	Wed, Apr 2, 12:40 PM

	F15436803: D7756.diff
	Tue, Mar 25, 4:35 PM

	F15428294: D7756.id17543.diff
	Sun, Mar 23, 6:58 PM

	F15413798: D7756.diff
	Wed, Mar 19, 9:27 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4224: Failure when trying to force push

Commits

Restricted Diffusion Commit
rP61c934449d17: Fix fatal in Git hook when a --force push completely rewrites a ref

Summary

Fixes T4224. If you git merge-base A B, and they have no ancestor, the command exits with an error. Assume errors mean "no ancestry" and continue.

Test Plan

Completely rewrite a repository with a --force push.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 11 2013, 10:33 PM

Closed by commit rP61c934449d17 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

15 lines

Diff 17546

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix fatal in Git hook when a --force push completely rewrites a refClosedPublicActions