Fix fatal in Git hook when a --force push completely rewrites a ref
ClosedPublic
Actions

Authored by epriestley on Dec 11 2013, 8:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 12:47 PM

	Unknown Object (File)
	Fri, Nov 15, 12:50 PM

	Unknown Object (File)
	Fri, Nov 15, 12:50 PM

	Unknown Object (File)
	Fri, Nov 15, 12:50 PM

	Unknown Object (File)
	Fri, Nov 15, 12:50 PM

	Unknown Object (File)
	Fri, Nov 15, 1:09 AM

	Unknown Object (File)
	Mon, Nov 11, 4:41 AM

	Unknown Object (File)
	Thu, Nov 7, 12:11 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4224: Failure when trying to force push

Commits

Restricted Diffusion Commit
rP61c934449d17: Fix fatal in Git hook when a --force push completely rewrites a ref

Summary

Fixes T4224. If you git merge-base A B, and they have no ancestor, the command exits with an error. Assume errors mean "no ancestry" and continue.

Test Plan

Completely rewrite a repository with a --force push.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 11 2013, 10:33 PM

Closed by commit rP61c934449d17 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

15 lines

Diff 17546

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix fatal in Git hook when a --force push completely rewrites a refClosedPublicActions