Fix fatal in Git hook when a --force push completely rewrites a ref
ClosedPublic
Actions

Authored by epriestley on Dec 11 2013, 8:31 PM.

Tags

None

Referenced Files

	F19652173: D7756.diff
	Fri, Feb 6, 1:07 PM

	F19554535: D7756.diff
	Thu, Jan 29, 11:11 PM

	F19283186: D7756.id.diff
	Dec 23 2025, 4:33 AM

	F19062043: D7756.id.diff
	Nov 29 2025, 2:33 PM

	F19057430: D7756.diff
	Nov 28 2025, 10:32 PM

	F19000745: D7756.id17546.diff
	Nov 21 2025, 12:44 AM

	F18854778: D7756.id.diff
	Nov 1 2025, 12:38 AM

	F18853650: D7756.id17546.diff
	Oct 31 2025, 6:32 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4224: Failure when trying to force push

Commits

Restricted Diffusion Commit
rP61c934449d17: Fix fatal in Git hook when a --force push completely rewrites a ref

Summary

Fixes T4224. If you git merge-base A B, and they have no ancestor, the command exits with an error. Assume errors mean "no ancestry" and continue.

Test Plan

Completely rewrite a repository with a --force push.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 11 2013, 10:33 PM

Closed by commit rP61c934449d17 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

15 lines

Diff 17546

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix fatal in Git hook when a --force push completely rewrites a refClosedPublicActions