Page MenuHomePhabricator

Make nonscalar field saves raise a more useful exception from LiskDAO
ClosedPublic

Authored by epriestley on Dec 6 2013, 1:26 AM.
Tags
None
Referenced Files
F19157044: D7725.id17443.diff
Dec 13 2025, 2:56 AM
F19095346: D7725.id.diff
Dec 4 2025, 4:54 AM
F19092800: D7725.diff
Dec 3 2025, 6:42 PM
F18859712: D7725.id.diff
Nov 2 2025, 4:57 AM
F18857910: D7725.diff
Nov 1 2025, 7:03 PM
F18819923: D7725.id17443.diff
Oct 22 2025, 11:08 AM
F18819628: D7725.diff
Oct 22 2025, 7:41 AM
F18739669: D7725.diff
Oct 1 2025, 10:30 PM
Subscribers

Details

Summary

If you do something like this:

// Missing $user->getPHID()!
$object->setUserPHID($user)->save();

...you get a very unhelpful exception:

Expected a scalar or null for %s conversion. Query: %s

This doesn't give you any hints about what's wrong. Instead, provide a more useful exception:

Unable to insert or update object of class DifferentialRevision, field 'title' has a nonscalar value.
Test Plan

{F87614}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped