Page MenuHomePhabricator

Make nonscalar field saves raise a more useful exception from LiskDAO
ClosedPublic

Authored by epriestley on Dec 6 2013, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2026, 5:25 AM
Unknown Object (File)
Mar 11 2026, 1:58 PM
Unknown Object (File)
Mar 5 2026, 2:15 AM
Unknown Object (File)
Mar 4 2026, 12:00 PM
Unknown Object (File)
Feb 15 2026, 11:38 PM
Unknown Object (File)
Feb 12 2026, 7:56 PM
Unknown Object (File)
Jan 31 2026, 7:03 PM
Unknown Object (File)
Jan 18 2026, 7:40 AM
Subscribers

Details

Summary

If you do something like this:

// Missing $user->getPHID()!
$object->setUserPHID($user)->save();

...you get a very unhelpful exception:

Expected a scalar or null for %s conversion. Query: %s

This doesn't give you any hints about what's wrong. Instead, provide a more useful exception:

Unable to insert or update object of class DifferentialRevision, field 'title' has a nonscalar value.
Test Plan

{F87614}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped