Page MenuHomePhabricator

Make nonscalar field saves raise a more useful exception from LiskDAO
ClosedPublic

Authored by epriestley on Dec 6 2013, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 10:45 AM
Unknown Object (File)
Sun, Feb 9, 10:45 AM
Unknown Object (File)
Sun, Feb 9, 10:45 AM
Unknown Object (File)
Sun, Feb 9, 10:45 AM
Unknown Object (File)
Mon, Feb 3, 9:12 AM
Unknown Object (File)
Mon, Feb 3, 9:02 AM
Unknown Object (File)
Thu, Jan 23, 5:00 AM
Unknown Object (File)
Wed, Jan 22, 3:18 PM
Subscribers

Details

Summary

If you do something like this:

// Missing $user->getPHID()!
$object->setUserPHID($user)->save();

...you get a very unhelpful exception:

Expected a scalar or null for %s conversion. Query: %s

This doesn't give you any hints about what's wrong. Instead, provide a more useful exception:

Unable to insert or update object of class DifferentialRevision, field 'title' has a nonscalar value.
Test Plan

{F87614}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped