Ref T4195. Add UI options to filter push logs by pusher and repository. Add a link from the repository view page to the push logs.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T4195: Implement pre-commit Herald rules
- Commits
- Restricted Diffusion Commit
rP3f5046014948: Allow repository push logs to be filtered by pusher and repository
Viewed a hosted repository, clicked logs link, saw logs. Filtered lgos by repo/pusher.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php | ||
|---|---|---|
| 15 | Why filter for type here and not below? Looks like both typeaheads are configured for end points that only return one type of object so its not necessary in either case? | |
| src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php | ||
|---|---|---|
| 15 | Users can access /pushlog/?repositories=T123,D22 and I don't want to fill the database up with garbage. If we don't filter, they'll prefill in the typeahead and things will generally be confusing. Users won't be able to typeahead them or cause any real damage, but this is a little cleaner. | |