Page MenuHomePhabricator

Migrate "Run Command" to use Drydock hosts
ClosedPublic

Authored by hach-que on Dec 5 2013, 2:50 AM.
Tags
None
Referenced Files
F15542786: D7707.id.diff
Fri, Apr 25, 6:50 PM
F15539554: D7707.id17409.diff
Fri, Apr 25, 2:26 AM
F15538159: D7707.diff
Thu, Apr 24, 5:41 PM
F15536791: D7707.id17409.diff
Thu, Apr 24, 10:55 AM
F15536790: D7707.id17408.diff
Thu, Apr 24, 10:55 AM
F15536789: D7707.id.diff
Thu, Apr 24, 10:55 AM
F15536788: D7707.diff
Thu, Apr 24, 10:55 AM
F15527605: D7707.id17408.diff
Tue, Apr 22, 5:05 AM

Details

Summary

This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.

Test Plan

Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.

Saw the results:

{F87377}

{F87378}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
6

bwahaha

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
15โ€“32

{burnittotheground}

15โ€“32

Macro burnittotheground:

Nice!

src/applications/harbormaster/step/CommandBuildStepImplementation.php
47

These are OK for now, I think Drydock predates the widespread use of PolicyQuery.