Page MenuHomePhabricator

Migrate "Run Command" to use Drydock hosts
ClosedPublic

Authored by hach-que on Dec 5 2013, 2:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 8, 6:41 AM
Unknown Object (File)
Mon, Aug 3, 11:04 PM
Unknown Object (File)
Jun 10 2026, 9:21 PM
Unknown Object (File)
Jun 6 2026, 10:59 AM
Unknown Object (File)
Apr 15 2026, 9:51 AM
Unknown Object (File)
Mar 30 2026, 10:26 AM
Unknown Object (File)
Feb 10 2026, 11:20 PM
Unknown Object (File)
Jan 17 2026, 2:39 AM

Details

Summary

This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.

Test Plan

Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.

Saw the results:

{F87377}

{F87378}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
6

bwahaha

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
15โ€“32

{burnittotheground}

15โ€“32

Macro burnittotheground:

Nice!

src/applications/harbormaster/step/CommandBuildStepImplementation.php
47

These are OK for now, I think Drydock predates the widespread use of PolicyQuery.