Page MenuHomePhabricator

Migrate "Run Command" to use Drydock hosts
ClosedPublic

Authored by hach-que on Dec 5 2013, 2:50 AM.
Tags
None
Referenced Files
F18789369: D7707.id.diff
Wed, Oct 15, 9:21 AM
F18764870: D7707.diff
Tue, Oct 7, 8:20 AM
F18761179: D7707.id17409.diff
Mon, Oct 6, 12:44 PM
F18594329: D7707.diff
Sep 12 2025, 5:49 PM
F18592393: D7707.id.diff
Sep 12 2025, 12:08 PM
F18588282: D7707.diff
Sep 11 2025, 11:48 PM
F18290577: D7707.diff
Aug 23 2025, 10:15 AM
F18112778: D7707.id.diff
Aug 12 2025, 8:28 PM

Details

Summary

This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.

Test Plan

Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.

Saw the results:

{F87377}

{F87378}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
6

bwahaha

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
15โ€“32

{burnittotheground}

15โ€“32

Macro burnittotheground:

Nice!

src/applications/harbormaster/step/CommandBuildStepImplementation.php
47

These are OK for now, I think Drydock predates the widespread use of PolicyQuery.