Page MenuHomePhabricator

Migrate "Run Command" to use Drydock hosts
ClosedPublic

Authored by hach-que on Dec 5 2013, 2:50 AM.
Tags
None
Referenced Files
F13163603: D7707.diff
Mon, May 6, 9:04 PM
Unknown Object (File)
Sat, May 4, 6:35 PM
Unknown Object (File)
Mon, Apr 29, 1:54 PM
Unknown Object (File)
Sun, Apr 28, 4:12 AM
Unknown Object (File)
Sun, Apr 28, 4:12 AM
Unknown Object (File)
Sun, Apr 28, 4:12 AM
Unknown Object (File)
Sun, Apr 28, 4:11 AM
Unknown Object (File)
Wed, Apr 24, 10:22 PM

Details

Summary

This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.

Test Plan

Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.

Saw the results:

{F87377}

{F87378}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
6

bwahaha

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
15โ€“32

{burnittotheground}

15โ€“32

Macro burnittotheground:

Nice!

src/applications/harbormaster/step/CommandBuildStepImplementation.php
47

These are OK for now, I think Drydock predates the widespread use of PolicyQuery.