Page MenuHomePhabricator

Migrate "Run Command" to use Drydock hosts
ClosedPublic

Authored by hach-que on Dec 5 2013, 2:50 AM.
Tags
None
Referenced Files
F19290275: D7707.id.diff
Tue, Dec 23, 8:44 AM
F19079431: D7707.id.diff
Mon, Dec 1, 8:58 PM
F19071207: D7707.diff
Sun, Nov 30, 6:49 PM
F18994067: D7707.diff
Nov 19 2025, 9:50 AM
F18904337: D7707.id.diff
Nov 8 2025, 8:39 AM
F18842903: D7707.id.diff
Oct 28 2025, 7:35 PM
F18839697: D7707.diff
Oct 27 2025, 6:19 PM
F18789369: D7707.id.diff
Oct 15 2025, 9:21 AM

Details

Summary

This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.

Test Plan

Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.

Saw the results:

{F87377}

{F87378}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
6

bwahaha

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
15โ€“32

{burnittotheground}

15โ€“32

Macro burnittotheground:

Nice!

src/applications/harbormaster/step/CommandBuildStepImplementation.php
47

These are OK for now, I think Drydock predates the widespread use of PolicyQuery.