Page MenuHomePhabricator

Migrate "Run Command" to use Drydock hosts
ClosedPublic

Authored by hach-que on Dec 5 2013, 2:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 2:47 PM
Unknown Object (File)
Thu, Dec 12, 11:45 AM
Unknown Object (File)
Thu, Dec 12, 5:04 AM
Unknown Object (File)
Sun, Dec 8, 11:39 AM
Unknown Object (File)
Wed, Dec 4, 7:52 AM
Unknown Object (File)
Tue, Dec 3, 7:05 PM
Unknown Object (File)
Sat, Nov 30, 1:58 PM
Unknown Object (File)
Tue, Nov 26, 10:53 AM

Details

Summary

This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.

Test Plan

Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.

Saw the results:

{F87377}

{F87378}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
6

bwahaha

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
15โ€“32

{burnittotheground}

15โ€“32

Macro burnittotheground:

Nice!

src/applications/harbormaster/step/CommandBuildStepImplementation.php
47

These are OK for now, I think Drydock predates the widespread use of PolicyQuery.