Page MenuHomePhabricator

Migrate "Run Command" to use Drydock hosts
ClosedPublic

Authored by hach-que on Dec 5 2013, 2:50 AM.
Tags
None
Referenced Files
F14061734: D7707.diff
Mon, Nov 18, 8:20 AM
F14053385: D7707.id17409.diff
Fri, Nov 15, 3:13 PM
F14052609: D7707.id17409.diff
Fri, Nov 15, 9:35 AM
F14052608: D7707.id17408.diff
Fri, Nov 15, 9:35 AM
F14052606: D7707.id.diff
Fri, Nov 15, 9:35 AM
F14052605: D7707.diff
Fri, Nov 15, 9:35 AM
F14047171: D7707.diff
Thu, Nov 14, 2:26 AM
F14035563: D7707.diff
Sun, Nov 10, 6:31 AM

Details

Summary

This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.

Test Plan

Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.

Saw the results:

{F87377}

{F87378}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
6

bwahaha

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
15โ€“32

{burnittotheground}

15โ€“32

Macro burnittotheground:

Nice!

src/applications/harbormaster/step/CommandBuildStepImplementation.php
47

These are OK for now, I think Drydock predates the widespread use of PolicyQuery.