Page MenuHomePhabricator

Migrate "Run Command" to use Drydock hosts
ClosedPublic

Authored by hach-que on Dec 5 2013, 2:50 AM.
Tags
None
Referenced Files
F15468369: D7707.diff
Thu, Apr 3, 11:54 PM
F15437756: D7707.id.diff
Tue, Mar 25, 9:18 PM
F15434460: D7707.id17409.diff
Tue, Mar 25, 3:49 AM
F15434090: D7707.diff
Tue, Mar 25, 1:57 AM
F15432850: D7707.diff
Mon, Mar 24, 7:57 PM
F15387097: D7707.id17408.diff
Sat, Mar 15, 1:49 AM
F15381858: D7707.diff
Fri, Mar 14, 9:40 AM
Unknown Object (File)
Feb 24 2025, 11:17 AM

Details

Summary

This migrates the "Run Remote Command" build step over to use Drydock hosts and Harbormaster artifacts.

Test Plan

Created a build plan with a "Lease Host" step and a "Run Command" step. Configured the "Run Command" step to use the artifact from the "Lease Host" step.

Saw the results:

{F87377}

{F87378}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
6

bwahaha

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php
15โ€“32

{burnittotheground}

15โ€“32

Macro burnittotheground:

Nice!

src/applications/harbormaster/step/CommandBuildStepImplementation.php
47

These are OK for now, I think Drydock predates the widespread use of PolicyQuery.