Page MenuHomePhabricator

Introduce HarbormasterBuildTarget to snapshot build steps through a build
ClosedPublic

Authored by hach-que on Dec 5 2013, 12:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:19 PM
Unknown Object (File)
Sat, Nov 16, 2:58 AM
Unknown Object (File)
Fri, Nov 15, 9:34 AM
Unknown Object (File)
Fri, Nov 15, 9:34 AM
Unknown Object (File)
Fri, Nov 15, 9:34 AM
Unknown Object (File)
Fri, Nov 15, 9:34 AM
Unknown Object (File)
Tue, Nov 12, 3:33 PM
Unknown Object (File)
Fri, Nov 8, 6:27 PM

Details

Summary

This implements build targets as outlined in D7582. Build targets represent an instance of a build step particular to the build. Logs and artifacts have been adjusted to attach to build targets instead of build / build step pairs.

Test Plan

Ran builds and clicked around the interface. Everything seemed to work.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Awesome, this looks great to me.

src/applications/harbormaster/controller/HarbormasterBuildViewController.php
58

pht()

66

pht