Page MenuHomePhabricator

Support Mercurial pretxnchangegroup hooks
ClosedPublic

Authored by epriestley on Dec 2 2013, 11:37 PM.
Tags
None
Referenced Files
F15408269: D7685.id17350.diff
Tue, Mar 18, 10:03 PM
F15403418: D7685.id17353.diff
Tue, Mar 18, 3:14 AM
F15397108: D7685.id17350.diff
Sun, Mar 16, 6:11 PM
F15393472: D7685.diff
Sat, Mar 15, 9:00 PM
F15391806: D7685.id.diff
Sat, Mar 15, 11:44 AM
Unknown Object (File)
Mon, Feb 24, 11:16 AM
Unknown Object (File)
Feb 10 2025, 5:58 AM
Unknown Object (File)
Feb 9 2025, 10:42 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4189: Install commit hooks in hosted repositories
Commits
Restricted Diffusion Commit
rPf93c6985ad84: Support Mercurial pretxnchangegroup hooks
Summary

Ref T4189. Fixes T2066. Mercurial has a lot of hooks so I'm not 100% sure this is all we need to install (we may need separate hooks for tags/bookmarks) but it should cover most of what we're after at least.

Test Plan
  • bin/repository pull'd a Mercurial repo and got a hook install.
  • Pushed to a Mercurial repository over SSH and HTTP, with good/bad hooks. Saw hooks fire.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
340

This is basically like "--bare" in Git, but should be much less problematic since the Mercurial bare and non-bare formats are almost identical. This is just a little cleaner/faster and saves a bit of disk space by not keeping a checked out working copy around when we don't actually need one.