Page MenuHomePhabricator

Support Mercurial pretxnchangegroup hooks
ClosedPublic

Authored by epriestley on Dec 2 2013, 11:37 PM.
Tags
None
Referenced Files
F15578725: D7685.id.diff
Tue, May 6, 8:35 PM
F15538443: D7685.id17353.diff
Thu, Apr 24, 7:21 PM
F15535992: D7685.id17353.diff
Thu, Apr 24, 8:02 AM
F15525716: D7685.id17350.diff
Mon, Apr 21, 4:23 PM
F15515452: D7685.id.diff
Fri, Apr 18, 10:33 AM
F15515349: D7685.id17353.diff
Fri, Apr 18, 9:49 AM
F15515347: D7685.id17350.diff
Fri, Apr 18, 9:49 AM
F15515346: D7685.id.diff
Fri, Apr 18, 9:49 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4189: Install commit hooks in hosted repositories
Commits
Restricted Diffusion Commit
rPf93c6985ad84: Support Mercurial pretxnchangegroup hooks
Summary

Ref T4189. Fixes T2066. Mercurial has a lot of hooks so I'm not 100% sure this is all we need to install (we may need separate hooks for tags/bookmarks) but it should cover most of what we're after at least.

Test Plan
  • bin/repository pull'd a Mercurial repo and got a hook install.
  • Pushed to a Mercurial repository over SSH and HTTP, with good/bad hooks. Saw hooks fire.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
340

This is basically like "--bare" in Git, but should be much less problematic since the Mercurial bare and non-bare formats are almost identical. This is just a little cleaner/faster and saves a bit of disk space by not keeping a checked out working copy around when we don't actually need one.