Page MenuHomePhabricator

Support Mercurial pretxnchangegroup hooks
ClosedPublic

Authored by epriestley on Dec 2 2013, 11:37 PM.
Tags
None
Referenced Files
F19096938: D7685.id.diff
Thu, Dec 4, 11:45 AM
F19092940: D7685.diff
Wed, Dec 3, 7:08 PM
F19082095: D7685.id17353.diff
Tue, Dec 2, 9:36 AM
F18851499: D7685.id17350.diff
Oct 31 2025, 1:47 AM
F18685208: D7685.diff
Sep 26 2025, 10:46 AM
F18630199: D7685.id.diff
Sep 16 2025, 11:00 AM
F18625757: D7685.id17353.diff
Sep 15 2025, 11:28 PM
F18547184: D7685.id17350.diff
Sep 8 2025, 5:29 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4189: Install commit hooks in hosted repositories
Commits
Restricted Diffusion Commit
rPf93c6985ad84: Support Mercurial pretxnchangegroup hooks
Summary

Ref T4189. Fixes T2066. Mercurial has a lot of hooks so I'm not 100% sure this is all we need to install (we may need separate hooks for tags/bookmarks) but it should cover most of what we're after at least.

Test Plan
  • bin/repository pull'd a Mercurial repo and got a hook install.
  • Pushed to a Mercurial repository over SSH and HTTP, with good/bad hooks. Saw hooks fire.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
340

This is basically like "--bare" in Git, but should be much less problematic since the Mercurial bare and non-bare formats are almost identical. This is just a little cleaner/faster and saves a bit of disk space by not keeping a checked out working copy around when we don't actually need one.