Page MenuHomePhabricator

Fix missing button to expand project action list on mobile.
ClosedPublic

Authored by brechtvl on Nov 27 2013, 7:58 PM.
Tags
None
Referenced Files
F15453769: D7666.diff
Sat, Mar 29, 2:14 PM
F15446122: D7666.id.diff
Thu, Mar 27, 5:19 PM
F15433104: D7666.id.diff
Mon, Mar 24, 9:24 PM
Unknown Object (File)
Feb 24 2025, 3:06 AM
Unknown Object (File)
Feb 15 2025, 6:52 AM
Unknown Object (File)
Feb 14 2025, 3:56 AM
Unknown Object (File)
Feb 6 2025, 9:09 AM
Unknown Object (File)
Feb 6 2025, 8:30 AM

Details

Test Plan

Go to a project page, make browser window narrow, click to expand action list.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is the slightly more standard/general fix, does that work?

diff --git a/src/applications/project/controller/PhabricatorProjectController.php b/src/applications/project/controller/PhabricatorProjectController.php
index a50d0af..8a72300 100644
--- a/src/applications/project/controller/PhabricatorProjectController.php
+++ b/src/applications/project/controller/PhabricatorProjectController.php
@@ -21,6 +21,10 @@ abstract class PhabricatorProjectController extends PhabricatorController {
     return $nav;
   }
 
+  public function buildApplicationMenu() {
+    return $this->buildSideNavView(true)->getMenu();
+  }
+
   public function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();

Oh -- I think the two do different things. Let me check...

Yeah, one fixes actions ("Edit Project...") one fixes the availability of the navigation menu.

I think we're going to pull the action element back out of the header, but this is fine for the moment.