Page MenuHomePhabricator

Fix missing button to expand project action list on mobile.
ClosedPublic

Authored by brechtvl on Nov 27 2013, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 9:37 AM
Unknown Object (File)
Tue, Apr 30, 11:28 PM
Unknown Object (File)
Sat, Apr 27, 4:49 PM
Unknown Object (File)
Mon, Apr 22, 10:30 PM
Unknown Object (File)
Fri, Apr 19, 10:36 AM
Unknown Object (File)
Wed, Apr 17, 8:32 PM
Unknown Object (File)
Apr 10 2024, 3:46 PM
Unknown Object (File)
Apr 8 2024, 11:30 PM

Details

Test Plan

Go to a project page, make browser window narrow, click to expand action list.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This is the slightly more standard/general fix, does that work?

diff --git a/src/applications/project/controller/PhabricatorProjectController.php b/src/applications/project/controller/PhabricatorProjectController.php
index a50d0af..8a72300 100644
--- a/src/applications/project/controller/PhabricatorProjectController.php
+++ b/src/applications/project/controller/PhabricatorProjectController.php
@@ -21,6 +21,10 @@ abstract class PhabricatorProjectController extends PhabricatorController {
     return $nav;
   }
 
+  public function buildApplicationMenu() {
+    return $this->buildSideNavView(true)->getMenu();
+  }
+
   public function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();

Oh -- I think the two do different things. Let me check...

Yeah, one fixes actions ("Edit Project...") one fixes the availability of the navigation menu.

I think we're going to pull the action element back out of the header, but this is fine for the moment.