Propagate "edit policy" and "view policy" when creating a new template task
ClosedPublic
Actions

Authored by epriestley on Nov 25 2013, 8:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 3, 9:08 AM

	Unknown Object (File)
	Wed, Jan 29, 7:30 AM

	Unknown Object (File)
	Wed, Jan 29, 7:30 AM

	Unknown Object (File)
	Wed, Jan 29, 7:30 AM

	Unknown Object (File)
	Jan 22 2025, 9:02 PM

	Unknown Object (File)
	Jan 21 2025, 9:11 AM

	Unknown Object (File)
	Jan 17 2025, 1:11 PM

	Unknown Object (File)
	Jan 16 2025, 5:34 AM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T4158: Copy policies when creating "Similar Task"

Commits

Restricted Diffusion Commit
rPe944cf8ff48e: Propagate "edit policy" and "view policy" when creating a new template task

Summary

Fixes T4158. Two possible refinements:

Maybe we should make all of these things respect ManiphestCapabilityEditAssign::CAPABILITY, etc. I think it's reasonable either way, and this is probably more intuitive and useful for most cases.
Maybe we should check that you can see the policies before copying them. Again, this is sort of reasonable either way.

Test Plan

Created a new task from a template, saw that it inherited policies.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que accepted this revision.Nov 25 2013, 9:37 PM

Closed by commit rPe944cf8ff48e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTaskEditController.php

2 lines

Diff 17278

View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Propagate "edit policy" and "view policy" when creating a new template taskClosedPublicActions