Paths

Table of Contentst

Display closed documents with crossed text in search result.
ClosedPublic
Actions

Authored by vvavrychuk on Nov 22 2013, 1:52 PM.

Tags

None

Referenced Files

	F14033146: D7626.diff
	Sat, Nov 9, 4:52 PM

	F14012362: D7626.id.diff
	Fri, Nov 1, 10:59 AM

	F14012361: D7626.id17260.diff
	Fri, Nov 1, 10:58 AM

	F14012288: D7626.diff
	Fri, Nov 1, 10:41 AM

	F13987169: D7626.id.diff
	Mon, Oct 21, 7:52 AM

	F13974104: D7626.id17216.diff
	Fri, Oct 18, 4:06 AM

	F13974099: D7626.diff
	Fri, Oct 18, 4:05 AM

	F13965072: D7626.id17294.diff
	Tue, Oct 15, 11:43 PM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPe67302a4c9c1: Display closed documents with crossed text in search result.

Summary

By default in search application document status field is "Open and Closed Documents".
Often searching with this default status I get confused that open and closed items in
search result are not distinguished.

Test Plan

Search and see open/closed issues distinguished.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vvavrychuk abandoned this revision.Nov 22 2013, 1:54 PM

Please see F84078

I mean please see F84076

I think this is reasonable. @epriestley any objections?

Two minor inlines.

src/applications/search/view/PhabricatorSearchResultView.php
57	Prefer the constant `PhabricatorObjectHandleStatus::STATUS_CLOSED` to the string literal `'closed'`.
58	Prefer `<del>` -- `<strike>` is deprecated in HTML4 and not present in HTML5.

Fixed review comments.

Thanks!

Closed by commit rPe67302a4c9c1 (authored by @vvavrychuk, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

view/

PhabricatorSearchResultView.php

7 lines

Diff 17294

View Options

src/applications/search/view/PhabricatorSearchResultView.php

Display closed documents with crossed text in search result.ClosedPublicActions