Page MenuHomePhabricator

Never raise policy exceptions for the omnipotent viewer
ClosedPublic

Authored by epriestley on Nov 18 2013, 10:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:29 PM
Unknown Object (File)
Thu, Apr 11, 7:03 AM
Unknown Object (File)
Tue, Apr 9, 11:12 AM
Unknown Object (File)
Tue, Apr 9, 11:12 AM
Unknown Object (File)
Tue, Apr 9, 11:12 AM
Unknown Object (File)
Tue, Apr 9, 10:48 AM
Unknown Object (File)
Tue, Apr 9, 10:25 AM
Unknown Object (File)
Fri, Apr 5, 12:37 AM
Subscribers

Details

Summary

Fixes T4109. If a revision has a bad repositoryPHID (for example, because the repository was deleted), DifferentialRevisionQuery calls didRejectResult() on it, which raises a policy exception, even if the viewer is omnipotent. This aborts the MessageParser, because it does not expect policy exceptions to be raised for an omnipotent viewer.

Fix this in two ways:

  1. Never raise a policy exception for an omnipotent viewer. I think this is the expected behavior and a reasonable rule.
  2. In this case, load the revision for an omnipotent viewer.

This feels a little gross, but it's the only place where we do this in the codebase right now. We can clean this up later on once it's more clear what the circumstances of checks like these are.

Test Plan

Set a revision to have an invalid repositoryPHID, ran message parser on it, got a clean parse.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped