DrydockResource has been updated to be policy-aware (although there are no policy columns).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- Restricted Maniphest Task
T4111: Use Drydock to allocate build machines for Harbormaster - Commits
- Restricted Diffusion Commit
rPd5715076513b: Update a few things in Drydock for policies
Clicked around in Drydock, viewed resources and leases, everything still seemed to work.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
The Drydock parts of this are fine to land if you want to split those out. The machine stuff I'd like to solidify all the ideas around a bit first, though. I don't currently imagine Harbormaster using specific build hosts, but rather build steps saying "Lease a <windows> machine with <some requirement> from Drydock".
| src/applications/drydock/query/DrydockResourceQuery.php | ||
|---|---|---|
| 25 | Let's omit this method if it doesn't actually do anything? | |
Comment Actions
In reality, now that we have the bin/drydock create-resource command, I'm not sure whether a UI is even needed. I'd imagine most scenarios will involve people hooking Drydock up to AWS EC2 and not running their own build machines in house.
(Also the UI ends up being really sketchy because you can only create new build machines; you can't edit them in Harbormaster and you can only view them in Drydock)