Page MenuHomePhabricator

Implement most of the administrative UI for approval queues
ClosedPublic

Authored by epriestley on Nov 13 2013, 2:27 AM.
Tags
None
Referenced Files
F14068762: D7573.diff
Wed, Nov 20, 12:47 AM
F14055675: D7573.diff
Sat, Nov 16, 2:37 PM
F14041885: D7573.diff
Mon, Nov 11, 10:30 PM
F14026043: D7573.diff
Thu, Nov 7, 10:37 PM
F14018122: D7573.diff
Tue, Nov 5, 5:03 AM
F14009799: D7573.diff
Wed, Oct 30, 11:51 PM
F14001138: D7573.id17105.diff
Fri, Oct 25, 4:30 AM
F13992105: D7573.id.diff
Tue, Oct 22, 2:23 PM
Subscribers

Details

Summary

Nothing fancy here, just:

  • UI to show users needing approval.
  • "Approve" and "Disable" actions.
  • Send "Approved" email on approve.
  • "Approve" edit + log operations.
  • "Wait for Approval" state for users who need approval.

There's still no natural way for users to end up not-approved -- you have to write directly to the database.

Test Plan

See screenshots.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

{F81257}

{F81258}

{F81259}

{F81260}

{F81261}

{F81262}

btrahan added inline comments.
src/applications/auth/controller/PhabricatorAuthNeedsApprovalController.php
27

haha

src/applications/people/editor/PhabricatorUserEditor.php
307

no user editor?

src/applications/auth/controller/PhabricatorAuthNeedsApprovalController.php
27

This might get us an "IT'S NOT SERIOUS ENOUGH" email, but the dialog currently looks junky with no buttons and implementing this button amused me greatly.

src/applications/people/editor/PhabricatorUserEditor.php
307

This is PhabricatorUserEditor, but it predates ApplicationTransactions so it's kind of funky and has a lot of code duplication compared to ApplicationTransactions (no shared code for database transaction management, e.g). We'll probably switch it over eventually, but I think it's lowish priority since it doesn't cause any concrete problems or really block anything (e.g., we don't need to publish any of this to news feed).

Well, maybe it would be nice to publish a "user signed up" story.

And maybe it would be nice to get a Herald email on a new user signup.

So maybe this does block stuff.

But no one has asked for these things, at least.