Page MenuHomePhabricator

Allow users to create buildables from diffs
ClosedPublic

Authored by hach-que on Nov 9 2013, 6:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 7:19 AM
Unknown Object (File)
Tue, Mar 26, 7:19 AM
Unknown Object (File)
Tue, Mar 26, 7:18 AM
Unknown Object (File)
Fri, Mar 22, 2:36 AM
Unknown Object (File)
Fri, Mar 22, 2:36 AM
Unknown Object (File)
Fri, Mar 22, 1:54 AM
Unknown Object (File)
Fri, Mar 22, 1:17 AM
Unknown Object (File)
Sat, Mar 16, 7:24 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T1049: Implement Harbormaster
Commits
Restricted Diffusion Commit
rPeccbbce9a282: Allow users to create buildables from diffs
Summary

Now that diffs have PHIDs we can create buildables for them.

This also adds buildable.diff in the variables list so the diff ID is available, and it also fixes the Cancel button on "Edit Plan" page so it redirects to the right place.

Test Plan

Created a buildable from a diff, ran a build plan against it that had echo ${buildable.diff} and got the right ID. Also tested the "Edit Plan" cancel redirect.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

(This has a tiny dependency on D7544 for DifferentialRevision -> DifferentialDiff in VariableBuildStepImplementation, so I'm holding it until that lands or we need it for something else.)