Page MenuHomePhabricator

Prevent crashes when more than one buildable for an object exists
ClosedPublic

Authored by hach-que on Nov 9 2013, 4:32 AM.
Tags
None
Referenced Files
F18442783: D7543.diff
Sun, Aug 31, 5:57 PM
F17896058: D7543.id17023.diff
Jul 29 2025, 6:45 AM
F17891597: D7543.id17020.diff
Jul 29 2025, 4:05 AM
F17886930: D7543.id17028.diff
Jul 29 2025, 1:21 AM
F17767713: D7543.diff
Jul 23 2025, 5:56 AM
Unknown Object (File)
Jun 15 2025, 11:22 PM
Unknown Object (File)
Jun 5 2025, 9:01 PM
Unknown Object (File)
May 9 2025, 1:17 AM

Details

Summary

This prevents a crash in applying build plans when more than one buildable exists for the same object. It also adds a check into the "New Manual Build" page to ensure that users can't create a buildable for an object that already has one.

Test Plan

Tried to create a buildable for an object that already has one and a nice friendly error appeared. Applied a build plan to a buildable whose object has two buildables and didn't get a crash any more.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

It also adds a check into the "New Manual Build" page to ensure that users can't create a buildable for an object that already has one.

At least tentatively, I think this should be allowed. If you're testing build plans, it lets you basically create a copy of some buildable and muck around with it without messing up the "real" one. There probably should be a flag to distinguish the "real" one from synthetic copies, though. For example, I wouldn't want a build to go red and send a bunch of alerts out because I messed up when configuring a new plan or whatever.

The existing code looks up the buildable by the object's PHID when applying a plan, so we'd need to change the code to allow a buildable's PHID to be passed through (otherwise it will always pick the first buildable, and not necessarily the one that you applied the plan to).

hach-que updated this revision to Unknown Object (????).Nov 9 2013, 4:46 AM

Remove change to buildable edit controller.

(Updating libphutil/ should clear that lint -- that class is new.)

Closed by commit rP43847d6bd7bb (authored by @hach-que, committed by @epriestley).