Page MenuHomePhabricator

Prevent crashes when more than one buildable for an object exists
ClosedPublic

Authored by hach-que on Nov 9 2013, 4:32 AM.
Tags
None
Referenced Files
F16058899: D7543.id17023.diff
Thu, Jun 5, 9:01 PM
Unknown Object (File)
Fri, May 9, 1:17 AM
Unknown Object (File)
May 7 2025, 2:00 AM
Unknown Object (File)
May 6 2025, 5:21 PM
Unknown Object (File)
May 5 2025, 9:15 PM
Unknown Object (File)
May 2 2025, 10:12 PM
Unknown Object (File)
Apr 27 2025, 12:08 PM
Unknown Object (File)
Apr 4 2025, 4:50 AM

Details

Summary

This prevents a crash in applying build plans when more than one buildable exists for the same object. It also adds a check into the "New Manual Build" page to ensure that users can't create a buildable for an object that already has one.

Test Plan

Tried to create a buildable for an object that already has one and a nice friendly error appeared. Applied a build plan to a buildable whose object has two buildables and didn't get a crash any more.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

It also adds a check into the "New Manual Build" page to ensure that users can't create a buildable for an object that already has one.

At least tentatively, I think this should be allowed. If you're testing build plans, it lets you basically create a copy of some buildable and muck around with it without messing up the "real" one. There probably should be a flag to distinguish the "real" one from synthetic copies, though. For example, I wouldn't want a build to go red and send a bunch of alerts out because I messed up when configuring a new plan or whatever.

The existing code looks up the buildable by the object's PHID when applying a plan, so we'd need to change the code to allow a buildable's PHID to be passed through (otherwise it will always pick the first buildable, and not necessarily the one that you applied the plan to).

hach-que updated this revision to Unknown Object (????).Nov 9 2013, 4:46 AM

Remove change to buildable edit controller.

(Updating libphutil/ should clear that lint -- that class is new.)

Closed by commit rP43847d6bd7bb (authored by @hach-que, committed by @epriestley).