Page MenuHomePhabricator

Add some light padding to code views.
ClosedPublic

Authored by asherkin on Nov 9 2013, 4:03 AM.
Tags
None
Referenced Files
F14012749: D7542.id17242.diff
Fri, Nov 1, 5:36 PM
F14011903: D7542.id17021.diff
Fri, Nov 1, 5:41 AM
F14011902: D7542.id17019.diff
Fri, Nov 1, 5:41 AM
F14011901: D7542.id.diff
Fri, Nov 1, 5:41 AM
F14011823: D7542.diff
Fri, Nov 1, 5:24 AM
F13997288: D7542.diff
Thu, Oct 24, 3:25 AM
F13958125: D7542.id17242.diff
Mon, Oct 14, 1:04 PM
F13957114: D7542.id.diff
Mon, Oct 14, 8:33 AM

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPb87a35c15e4e: Add some light padding to code views.
Summary

Source code output currently juts up against the border of its container, making the first and last lines harder to read, this diff adds some padding inside.

Test Plan

{F79908} {F79907}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Need to special-case differential.

asherkin updated this revision to Unknown Object (????).Nov 9 2013, 4:38 AM

Just target the general source code view (Paste, Harbormaster build output), Differential is too special.

This looks good to me, but I'll defer to @chad.

Why not also differential?

The CSS rules / code changes required to do it would get rather complicated, and I figured it would be saner to tackle after T2004.
Paste was the big one that needed this change, Differential already has lots of neutral space around it.

@asherkin, I gave you commit access since you seem not-that-untrustworthy:

  • Add a public SSH key in Settings > SSH Public Keys
  • Run git remote set-url origin dweller@secure.phabricator.com:diffusion/P/ in phabricator/ to move origin to the new self-hosted master.
  • arc land