Page MenuHomePhabricator
Differential D7494

Split Diffusion VSC serve code into its own controller
ClosedPublic
Actions

Authored by epriestley on Nov 4 2013, 10:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:13 AM
Unknown Object (File)
Tue, Dec 17, 5:24 AM
Unknown Object (File)
Sun, Dec 8, 7:32 AM
Unknown Object (File)
Sun, Dec 8, 7:32 AM
Unknown Object (File)
Sun, Dec 8, 7:32 AM
Unknown Object (File)
Sun, Dec 8, 7:32 AM
Unknown Object (File)
Sun, Dec 8, 7:32 AM
Unknown Object (File)
Fri, Dec 6, 8:02 AM
View All Files
Subscribers
aran
hach-que

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP44a40eaf57b0: Split Diffusion VSC serve code into its own controller
Summary

This is starting to get a bit sizable and it turns out Mercurial is sort of a beast, so split the VCS serve stuff into a separate controller.

Test Plan

Pushed and pulled an authenticated Git repository.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que added a comment.Nov 4 2013, 11:16 PM

Also ensure this is tested with public policy turned off.. I don't want this stuff breaking tomorrow morning when we start using the Git hosting.

btrahan accepted this revision.Nov 5 2013, 2:03 AM
epriestley updated this revision to Unknown Object (????).Nov 7 2013, 1:55 AM
  • Rebase on password/user agent changes.
  • cloned/pushed Git repo with allow public on.
  • cloned/pusehd Git repo with allow public off.
epriestley closed this revision.Nov 7 2013, 1:56 AM

Closed by commit rP44a40eaf57b0 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
controller/
359 lines
DiffusionServeController.php
DiffusionController.php
320 lines

Diff 16962

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
Phabricator · Built by Phacility