Paths

Table of Contentst

Disable CSRF checks on Git push when updating repository.
ClosedPublic
Actions

Authored by hach-que on Nov 4 2013, 7:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 26, 6:34 AM

	Unknown Object (File)
	Fri, Feb 21, 12:05 PM

	Unknown Object (File)
	Mon, Feb 17, 2:55 AM

	Unknown Object (File)
	Mon, Feb 17, 1:45 AM

	Unknown Object (File)
	Sun, Feb 16, 6:19 PM

	Unknown Object (File)
	Thu, Feb 13, 9:59 AM

	Unknown Object (File)
	Sun, Feb 9, 10:28 AM

	Unknown Object (File)
	Sun, Feb 9, 10:28 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4052: Crash when pushing content to Git repository

Commits

Restricted Diffusion Commit
rP3e2efaf00e57: Disable CSRF checks on Git push when updating repository.

Summary

This disables CSRF checking around the $repository->writeStatusMessage so that pushing changes over HTTP to Git repositories doesn't fail miserably.

Test Plan

Applied this fix and I could git push to hosted repositories again.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

A slightly better approach is:

$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
// ...
unset($unguarded);

This does the right thing if the intervening code throws an exception. I'll tweak that in the pull. Thanks!

I also made a small change to populate:

'REMOTE_USER' => $viewer->getUsername(),

...since Git seemed cranky without it when I was testing the $unguarded flavor.

Closed by commit rP3e2efaf00e57 (authored by @hach-que, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

17 lines

Diff 16879

View Options

src/applications/diffusion/controller/DiffusionController.php

Disable CSRF checks on Git push when updating repository.ClosedPublicActions