Page MenuHomePhabricator

The poop emoji (U+1F4A9) breaks differential
AbandonedPublic

Authored by NorthIsUp on Nov 1 2013, 9:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 22, 6:25 AM
Unknown Object (File)
Wed, Oct 7, 1:45 AM
Unknown Object (File)
Aug 26 2026, 5:04 PM
Unknown Object (File)
Jun 22 2026, 9:21 AM
Unknown Object (File)
Apr 10 2026, 4:13 AM
Unknown Object (File)
Mar 29 2026, 3:29 PM
Unknown Object (File)
Mar 28 2026, 10:45 AM
Unknown Object (File)
Mar 28 2026, 5:16 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
Test Plan

not a real diff

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Although for the special case of diffs themselves (vs comment text, titles, summaries, etc.) I think we're going to move toward binary storage + runtime mangling.

Just pushing this out of my queue; see T4045 for strategy if you're feeling brave about fixing this.