The poop emoji (U+1F4A9) breaks differential
AbandonedPublic
Actions

Authored by NorthIsUp on Nov 1 2013, 9:10 PM.

Tags

None

Referenced Files

	F18106816: D7472.diff
	Sun, Aug 10, 11:24 PM

	F17948831: D7472.id.diff
	Thu, Jul 31, 10:06 PM

	F17930295: D7472.diff
	Wed, Jul 30, 5:53 PM

	Unknown Object (File)
	Apr 25 2025, 4:06 AM

	Unknown Object (File)
	Apr 16 2025, 6:16 PM

	Unknown Object (File)
	Apr 15 2025, 3:39 PM

	Unknown Object (File)
	Apr 15 2025, 1:21 AM

	Unknown Object (File)
	Apr 11 2025, 7:09 AM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4045: Store diffs as binary, not UTF-8

Test Plan

not a real diff

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

See T1191.

Although for the special case of diffs themselves (vs comment text, titles, summaries, etc.) I think we're going to move toward binary storage + runtime mangling.

Just pushing this out of my queue; see T4045 for strategy if you're feeling brave about fixing this.

NorthIsUp abandoned this revision.Mar 4 2014, 9:02 PM

Revision Contents
Changeset List

Path

Size

jenkins/

phabricator-post.py

8 lines

Diff 16843

View Options

jenkins/phabricator-post.py

The poop emoji (U+1F4A9) breaks differentialAbandonedPublicActions