Page MenuHomePhabricator

The poop emoji (U+1F4A9) breaks differential
AbandonedPublic

Authored by NorthIsUp on Nov 1 2013, 9:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 1:00 PM
Unknown Object (File)
Feb 4 2024, 2:32 AM
Unknown Object (File)
Jan 9 2024, 8:22 PM
Unknown Object (File)
Dec 23 2023, 11:15 PM
Unknown Object (File)
Dec 21 2023, 8:40 PM
Unknown Object (File)
Dec 16 2023, 2:18 PM
Unknown Object (File)
Dec 7 2023, 3:23 AM
Unknown Object (File)
Nov 23 2023, 12:01 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
Test Plan

not a real diff

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Although for the special case of diffs themselves (vs comment text, titles, summaries, etc.) I think we're going to move toward binary storage + runtime mangling.

Just pushing this out of my queue; see T4045 for strategy if you're feeling brave about fixing this.