The poop emoji (U+1F4A9) breaks differential
AbandonedPublic
Actions

Authored by NorthIsUp on Nov 1 2013, 9:10 PM.

Tags

None

Referenced Files

	F18857915: D7472.id.diff
	Sat, Nov 1, 7:04 PM

	F18853303: D7472.diff
	Fri, Oct 31, 3:42 PM

	F18789019: D7472.diff
	Oct 15 2025, 7:35 AM

	F18739240: D7472.id.diff
	Oct 1 2025, 8:30 PM

	F18734515: D7472.id.diff
	Sep 30 2025, 10:55 PM

	F18731835: D7472.diff
	Sep 30 2025, 3:19 PM

	F18514368: D7472.id.diff
	Sep 5 2025, 10:10 AM

	F18480695: D7472.diff
	Sep 3 2025, 11:21 AM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4045: Store diffs as binary, not UTF-8

Test Plan

not a real diff

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

See T1191.

Although for the special case of diffs themselves (vs comment text, titles, summaries, etc.) I think we're going to move toward binary storage + runtime mangling.

Just pushing this out of my queue; see T4045 for strategy if you're feeling brave about fixing this.

NorthIsUp abandoned this revision.Mar 4 2014, 9:02 PM

Revision Contents
Changeset List

Path

Size

jenkins/

phabricator-post.py

8 lines

Diff 16843

View Options

jenkins/phabricator-post.py

The poop emoji (U+1F4A9) breaks differentialAbandonedPublicActions