Page MenuHomePhabricator
Differential D7427

Don't pull updates for repositories marked as hosted
ClosedPublic
Actions

Authored by epriestley on Oct 26 2013, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 16, 5:40 PM
Unknown Object (File)
Thu, Sep 12, 10:37 PM
Unknown Object (File)
Thu, Sep 12, 10:37 PM
Unknown Object (File)
Thu, Sep 12, 10:37 PM
Unknown Object (File)
Thu, Sep 12, 10:37 PM
Unknown Object (File)
Sat, Aug 31, 12:53 PM
Unknown Object (File)
Aug 19 2024, 6:26 AM
Unknown Object (File)
Aug 17 2024, 9:43 PM
View All Files
Subscribers
aran

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP0965f0041a5c: Don't pull updates for repositories marked as hosted
Summary
  • Don't try to pull hosted repos.
  • Also, fix the --verbose + --trace interaction for bin/repository.
  • Also, fix a couple of unit tests which got tweaked earlier.
Test Plan
$ ./bin/repository pull GTEST --verbose
Pulling 'GTEST'...
Repository "GTEST" is hosted, so Phabricator does not pull updates for it.
Done.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que accepted this revision.Oct 26 2013, 10:21 PM

Test plan does work as expected, but there's still quite a few exceptions and errors occurring in the daemons due to tracking configuration.

See P962 and P963 for related exceptions.

epriestley closed this revision.Oct 29 2013, 10:33 PM

Closed by commit rP0965f0041a5c (authored by @epriestley).

Revision Contents
Changeset List

Diff 16754

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
View Options

src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php

Loading...
Phabricator · Built by Phacility