- Add web UI for configuring SSH hosting.
- Route git reads (git-upload-pack over SSH).
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rPbb4904553f2c: Route some VCS connections over SSH
>>> orbital ~ $ git clone ssh://127.0.0.1/ Cloning into '127.0.0.1'... Exception: Unrecognized repository path "/". Expected a path like "/diffusion/X/". fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. >>> orbital ~ $ git clone ssh://127.0.0.1/diffusion/X/ Cloning into 'X'... Exception: No repository "X" exists! fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. >>> orbital ~ $ git clone ssh://127.0.0.1/diffusion/MT/ Cloning into 'MT'... Exception: This repository is not available over SSH. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. >>> orbital ~ $ git clone ssh://127.0.0.1/diffusion/P/ Cloning into 'P'... Exception: TODO: Implement serve over SSH. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/diffusion/ssh/DiffusionSSHWorkflow.php | ||
|---|---|---|
| 39–48 | I don't think it does but wanted to ask - does this mesh well with any of the existing diffusion code on parsing out the call sign? I don't think it does as I think that logic is all in URI mapping stuff at a very low level. | |
Comment Actions
The rules are very slightly different (in this case, the initial "/" may not be present) but I can probably clean this one and the one in DiffusionController up a bit. The one in the URI map might be harder to consolidate, but it's also much simpler.