Page MenuHomePhabricator

Remove horrible old repository edit controller
ClosedPublic

Authored by epriestley on Oct 25 2013, 11:25 PM.
Tags
None
Referenced Files
F15419574: D7410.diff
Fri, Mar 21, 7:07 AM
F15412027: D7410.diff
Wed, Mar 19, 10:55 AM
F15403049: D7410.id.diff
Tue, Mar 18, 1:44 AM
F15396698: D7410.id16742.diff
Sun, Mar 16, 3:52 PM
F15369942: D7410.id.diff
Wed, Mar 12, 8:50 AM
F15312461: D7410.id.diff
Thu, Mar 6, 3:06 PM
Unknown Object (File)
Sat, Mar 1, 2:01 PM
Unknown Object (File)
Thu, Feb 27, 3:13 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc585f97e90d2: Remove horrible old repository edit controller
Summary

Ref T2231. I didn't port these options over, so they're still supported but have no edit UI:

  • Pull Frequency (confusing/not useful, I think?)
  • Default Owners Path (probably used only by Facebook and only in the E repository)
  • Show user in public repository URL (probably mostly obsolete with hosting?)

We can add those back if users notice, but they seem like the three least useful options so I'm going to see if we can get away with removing them.

Test Plan

Clicked "Edit" from Repositories, got kicked into the nice new Diffusion edit UI instead of the old one.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Cool. I like the strat here too.