Page MenuHomePhabricator

Remove horrible old repository edit controller
ClosedPublic

Authored by epriestley on Oct 25 2013, 11:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 13, 11:52 PM
Unknown Object (File)
Dec 22 2024, 2:48 AM
Unknown Object (File)
Dec 21 2024, 7:39 PM
Unknown Object (File)
Dec 14 2024, 4:11 PM
Unknown Object (File)
Dec 11 2024, 7:42 AM
Unknown Object (File)
Dec 9 2024, 4:21 AM
Unknown Object (File)
Dec 9 2024, 4:21 AM
Unknown Object (File)
Dec 9 2024, 4:21 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc585f97e90d2: Remove horrible old repository edit controller
Summary

Ref T2231. I didn't port these options over, so they're still supported but have no edit UI:

  • Pull Frequency (confusing/not useful, I think?)
  • Default Owners Path (probably used only by Facebook and only in the E repository)
  • Show user in public repository URL (probably mostly obsolete with hosting?)

We can add those back if users notice, but they seem like the three least useful options so I'm going to see if we can get away with removing them.

Test Plan

Clicked "Edit" from Repositories, got kicked into the nice new Diffusion edit UI instead of the old one.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Cool. I like the strat here too.