Page MenuHomePhabricator

Remove horrible old repository edit controller
ClosedPublic

Authored by epriestley on Oct 25 2013, 11:25 PM.
Tags
None
Referenced Files
F17851983: D7410.id.diff
Jul 27 2025, 12:01 PM
F17828106: D7410.diff
Jul 26 2025, 8:52 AM
F17816941: D7410.diff
Jul 25 2025, 11:12 PM
F17814808: D7410.id16742.diff
Jul 25 2025, 9:31 PM
F17765057: D7410.diff
Jul 23 2025, 1:23 AM
F17596483: D7410.diff
Jul 8 2025, 11:25 AM
Unknown Object (File)
May 24 2025, 6:12 PM
Unknown Object (File)
May 20 2025, 7:10 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc585f97e90d2: Remove horrible old repository edit controller
Summary

Ref T2231. I didn't port these options over, so they're still supported but have no edit UI:

  • Pull Frequency (confusing/not useful, I think?)
  • Default Owners Path (probably used only by Facebook and only in the E repository)
  • Show user in public repository URL (probably mostly obsolete with hosting?)

We can add those back if users notice, but they seem like the three least useful options so I'm going to see if we can get away with removing them.

Test Plan

Clicked "Edit" from Repositories, got kicked into the nice new Diffusion edit UI instead of the old one.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Cool. I like the strat here too.