Page MenuHomePhabricator

Fix logged-out Diffusion calls to Conduit
ClosedPublic

Authored by epriestley on Oct 22 2013, 8:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 11:46 PM
Unknown Object (File)
Sat, Feb 1, 4:29 AM
Unknown Object (File)
Tue, Jan 28, 5:58 AM
Unknown Object (File)
Jan 22 2025, 10:10 AM
Unknown Object (File)
Jan 1 2025, 5:35 PM
Unknown Object (File)
Dec 17 2024, 3:52 AM
Unknown Object (File)
Dec 13 2024, 6:06 PM
Unknown Object (File)
Nov 29 2024, 8:44 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP90b83d7a92c5: Fix logged-out Diffusion calls to Conduit
Summary

Conduit doesn't currently have an analog to "shouldAllowPublic", so the recent policy checks added here caught legitimate Conduit calls when viewing Diffusion as a logged-out user.

Add shouldAllowPublic() and set it for all the Diffusion queries.

(More calls probably need this, but we can add it when we hit them.)

Test Plan

Looked at Diffusion as a logged-out user with public access enabled.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped