Page MenuHomePhabricator

Clean up supplemental capabilitiy checks in transaction edits
ClosedPublic

Authored by epriestley on Oct 18 2013, 10:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 10:33 PM
Unknown Object (File)
Oct 20 2024, 8:22 AM
Unknown Object (File)
Oct 19 2024, 5:29 AM
Unknown Object (File)
Oct 15 2024, 6:30 PM
Unknown Object (File)
Sep 20 2024, 12:13 AM
Unknown Object (File)
Sep 20 2024, 12:13 AM
Unknown Object (File)
Sep 20 2024, 12:13 AM
Unknown Object (File)
Sep 20 2024, 12:13 AM
Subscribers

Details

Summary

We have this commented-out chunk of code now which was originally buggy and is now just nonfunctional.

For now, the core edit types don't always require CAN_EDIT (e.g., subscribe, comment, add edges), except for editing the edit policy itself, which always does. Add a supplemental capability check there and let everything else go through with CAN_VIEW. We can buff the policy checks on application editors over time, they all require appropriate capabilities to get to in the first place anyway.

Test Plan

Created and edited some tasks without getting overwhelmed with policy exceptions.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped