Distinguish between invalid/broken handles and filtered handles
ClosedPublic
Actions

Authored by epriestley on Oct 17 2013, 1:50 AM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T603: Support permissions/policies in all Phabricator applications

Commits

Restricted Diffusion Commit
rP95c2b03fc8e5: Distinguish between invalid/broken handles and filtered handles

Summary

Ref T603. Currently, we render handles the user doesn't have permission to see in a manner identical to handles that don't exist. This is confusing, and not required by policies (which restrict content, but permit knowledge that an object exists).

Instead, render them in different styles. Bad/invalid objects look like:

Unknown Object (Task)

Restricted objects look like:

Restricted Task

...where [o] is the padlock icon.

Test Plan

{F71100}

{F71101}

It's possible this renders weird somewhere, but I wasn't immediately able to find any issues. Yell if you see something.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Maybe we'll need some sort of tool tip some day about why it was restricted?

Closed by commit rP95c2b03fc8e5 (authored by @epriestley).

We could pop the "policy explanation" dialog but it seems pretty heavy and I'm not sure it will be too important. It also discloses PHIDs more easily than you can currently get them, which is probably fine but maybe fishy. And it's a bit more work and slightly more likely to break something. So I'm thinking wait-and-see-if-it-seems-useful.