Page MenuHomePhabricator

Modernize policies in Paste and Macro
ClosedPublic

Authored by epriestley on Oct 15 2013, 12:30 AM.
Tags
None
Referenced Files
F13990554: D7317.id.diff
Tue, Oct 22, 4:24 AM
F13987977: D7317.diff
Oct 21 2024, 12:25 PM
F13982133: D7317.diff
Oct 19 2024, 9:28 PM
F13982120: D7317.id.diff
Oct 19 2024, 9:24 PM
F13982118: D7317.id16482.diff
Oct 19 2024, 9:23 PM
F13982109: D7317.id16506.diff
Oct 19 2024, 9:20 PM
Unknown Object (File)
Oct 13 2024, 10:23 PM
Unknown Object (File)
Sep 21 2024, 8:08 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T603: Support permissions/policies in all Phabricator applications
Commits
Restricted Diffusion Commit
rP8c1c6fec5ac9: Modernize policies in Paste and Macro
Summary

Ref T603. Fixes T2823. This updates Paste and Macro.

  • Paste
    • Added default view policy.
    • I didn't add a "create" policy, since I can't come up with any realistic scenario where you'd give users access to pastes but not let them create them.
  • Macro
    • Added a "manage" policy, which covers creating and editing macros. This lets an install only allow "People With An Approved Sense of Humor" or whatever to create macros.
    • Removed the "edit" policy, since giving individual users access to specific macros doesn't make much sense to me.
    • Changed the view policy to the "most public" policy the install allows.
    • Added view policy information to the header.

Also fix a couple of minor things in Maniphest.

Test Plan
  • Set Paste policy, created pastes via web and Conduit, saw they got the right default policies.
  • Set Macro policy, tried to create/edit macros with valid and unauthorized users.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped