Page MenuHomePhabricator

Don't try to activate disabled items in dropdown menus
ClosedPublic

Authored by epriestley on Oct 14 2013, 12:26 AM.
Tags
None
Referenced Files
F18672455: D7293.id16448.diff
Sep 25 2025, 7:34 AM
F18672234: D7293.id.diff
Sep 25 2025, 7:03 AM
F18671941: D7293.id16423.diff
Sep 25 2025, 6:00 AM
F18670632: D7293.diff
Sep 25 2025, 12:55 AM
F18669742: D7293.diff
Sep 24 2025, 9:46 PM
F18142572: D7293.id16423.diff
Aug 14 2025, 1:06 PM
F18142022: D7293.id16448.diff
Aug 14 2025, 11:17 AM
F18113051: D7293.diff
Aug 12 2025, 11:23 PM
Subscribers

Details

Summary

Fixes an issue where the user could click a disabled dropdown menu item and get an exception or some other nonsense. Instead, just don't activate anything.

Test Plan

Clicked a disabled header, like "Members of project" in the policy dropdown.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Although I'm sure your review was exceptionally through, I'll wait for @btrahan to take a look too.