Page MenuHomePhabricator

Allow custom policies to be loaded and exeucuted by the policy filter
ClosedPublic

Authored by epriestley on Oct 13 2013, 1:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 1:37 PM
Unknown Object (File)
Feb 8 2024, 1:30 PM
Unknown Object (File)
Jan 24 2024, 2:02 AM
Unknown Object (File)
Jan 16 2024, 10:10 PM
Unknown Object (File)
Dec 21 2023, 2:33 AM
Unknown Object (File)
Nov 25 2023, 7:30 AM
Unknown Object (File)
Nov 23 2023, 11:59 AM
Unknown Object (File)
Nov 12 2023, 1:26 PM
Subscribers

Details

Summary

Ref T603. Adds code to actually execute custom policies. (There's still no way to select them in the UI.)

Test Plan
  • Added and executed unit tests.
  • Edited policies in existing applications.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Although I'm sure your review was very thorough, it might be best for @btrahan to take a look too.

btrahan added inline comments.
src/applications/policy/query/PhabricatorPolicyQuery.php
73–75

you could lose this else or lose the initialization on line 66

204

s/thought/though/

epriestley updated this revision to Unknown Object (????).Oct 14 2013, 6:46 PM
  • Remove extra initialization.
  • Fix comment typo.