Page MenuHomePhabricator

Allow custom policies to be loaded and exeucuted by the policy filter
ClosedPublic

Authored by epriestley on Oct 13 2013, 1:21 AM.
Tags
None
Referenced Files
F15530840: D7292.diff
Wed, Apr 23, 7:25 AM
F15508922: D7292.id16446.diff
Wed, Apr 16, 7:20 AM
F15464754: D7292.diff
Wed, Apr 2, 12:42 PM
F15452010: D7292.id16446.diff
Sat, Mar 29, 1:08 AM
F15448627: D7292.id16421.diff
Fri, Mar 28, 6:00 AM
F15443717: D7292.id.diff
Thu, Mar 27, 5:49 AM
F15441820: D7292.diff
Mar 26 2025, 8:13 PM
F15407808: D7292.id.diff
Mar 18 2025, 7:43 PM
Subscribers

Details

Summary

Ref T603. Adds code to actually execute custom policies. (There's still no way to select them in the UI.)

Test Plan
  • Added and executed unit tests.
  • Edited policies in existing applications.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Although I'm sure your review was very thorough, it might be best for @btrahan to take a look too.

btrahan added inline comments.
src/applications/policy/query/PhabricatorPolicyQuery.php
73–75

you could lose this else or lose the initialization on line 66

204

s/thought/though/

epriestley updated this revision to Unknown Object (????).Oct 14 2013, 6:46 PM
  • Remove extra initialization.
  • Fix comment typo.