Page MenuHomePhabricator

Allow custom policies to be loaded and exeucuted by the policy filter
ClosedPublic

Authored by epriestley on Oct 13 2013, 1:21 AM.
Tags
None
Referenced Files
F18848483: D7292.id.diff
Thu, Oct 30, 4:56 AM
F18846453: D7292.diff
Wed, Oct 29, 6:57 PM
F18715765: D7292.id16445.diff
Sep 29 2025, 10:43 AM
F18684548: D7292.diff
Sep 26 2025, 9:41 AM
F18669051: D7292.diff
Sep 24 2025, 6:13 PM
F18619682: D7292.id.diff
Sep 15 2025, 3:08 AM
F18586138: D7292.diff
Sep 11 2025, 5:35 PM
F18198081: D7292.id16446.diff
Aug 17 2025, 10:34 PM
Subscribers

Details

Summary

Ref T603. Adds code to actually execute custom policies. (There's still no way to select them in the UI.)

Test Plan
  • Added and executed unit tests.
  • Edited policies in existing applications.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Although I'm sure your review was very thorough, it might be best for @btrahan to take a look too.

btrahan added inline comments.
src/applications/policy/query/PhabricatorPolicyQuery.php
73–75

you could lose this else or lose the initialization on line 66

204

s/thought/though/

epriestley updated this revision to Unknown Object (????).Oct 14 2013, 6:46 PM
  • Remove extra initialization.
  • Fix comment typo.