Page MenuHomePhabricator
Differential D7292

Allow custom policies to be loaded and exeucuted by the policy filter
ClosedPublic
Actions

Authored by epriestley on Oct 13 2013, 1:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 11:13 AM
Unknown Object (File)
Wed, Dec 18, 6:45 AM
Unknown Object (File)
Tue, Dec 17, 10:02 PM
Unknown Object (File)
Sat, Dec 14, 7:44 PM
Unknown Object (File)
Sun, Dec 8, 9:05 PM
Unknown Object (File)
Sun, Dec 8, 7:33 PM
Unknown Object (File)
Tue, Nov 26, 1:59 PM
Unknown Object (File)
Nov 10 2024, 12:08 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T603: Support permissions/policies in all Phabricator applications
Commits
Restricted Diffusion Commit
rP67b17239b8e6: Allow custom policies to be loaded and exeucuted by the policy filter
Summary

Ref T603. Adds code to actually execute custom policies. (There's still no way to select them in the UI.)

Test Plan
  • Added and executed unit tests.
  • Edited policies in existing applications.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

changyuheng requested changes to this revision.Oct 13 2013, 8:14 AM

test

changyuheng accepted this revision.Oct 13 2013, 8:21 AM

test

epriestley requested a review of this revision.Oct 13 2013, 10:50 AM

Although I'm sure your review was very thorough, it might be best for @btrahan to take a look too.

btrahan accepted this revision.Oct 14 2013, 4:50 PM
btrahan added inline comments.
src/applications/policy/query/PhabricatorPolicyQuery.php
73–75

you could lose this else or lose the initialization on line 66

204

s/thought/though/

epriestley updated this revision to Unknown Object (????).Oct 14 2013, 6:46 PM
  • Remove extra initialization.
  • Fix comment typo.
epriestley closed this revision.Oct 14 2013, 6:46 PM

Closed by commit rP67b17239b8e6 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
storage/
2 lines
policy/
__tests__/
113 lines
filter/
87 lines
query/
169 lines
rule/
7 lines
storage/
53 lines

Diff 16446

View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/policy/__tests__/PhabricatorPolicyDataTestCase.php

Loading...
View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

Loading...
View Options

src/applications/policy/query/PhabricatorPolicyQuery.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRuleUsers.php

Loading...
View Options

src/applications/policy/storage/PhabricatorPolicy.php

Loading...
Phabricator · Built by Phacility