Fix two issues where StandardPageView assumes it will always have access to a user
ClosedPublic
Actions

Authored by epriestley on Oct 11 2013, 2:40 AM.

Tags

None

Referenced Files

	F18839853: D7286.diff
	Mon, Oct 27, 7:21 PM

	F18671156: D7286.id.diff
	Sep 25 2025, 2:52 AM

	F18668945: D7286.diff
	Sep 24 2025, 5:14 PM

	F18616789: D7286.diff
	Sep 14 2025, 7:01 PM

	F18602631: D7286.id.diff
	Sep 13 2025, 3:41 PM

	F18597426: D7286.diff
	Sep 13 2025, 2:52 AM

	F18597423: D7286.diff
	Sep 13 2025, 2:51 AM

	F18162726: D7286.id16419.diff
	Aug 15 2025, 4:59 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP122f643d6f36: Fix two issues where StandardPageView assumes it will always have access to a…

Summary

If we hit an exception very early, the request may not have a user yet. Don't assume it will.

Test Plan

Broke MySQL config on purpose to test some stuff, loaded Phabricator, got a nice error page instead of a super-fatal one.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 11 2013, 10:25 PM

Closed by commit rP122f643d6f36 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

view/

page/

PhabricatorStandardPageView.php

10 lines

Diff 16419

View Options

src/view/page/PhabricatorStandardPageView.php

Fix two issues where StandardPageView assumes it will always have access to a userClosedPublicActions