Fix two issues where StandardPageView assumes it will always have access to a user
ClosedPublic
Actions

Authored by epriestley on Oct 11 2013, 2:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 24, 9:49 AM

	Unknown Object (File)
	Fri, Jan 24, 9:48 AM

	Unknown Object (File)
	Fri, Jan 24, 9:36 AM

	Unknown Object (File)
	Sat, Jan 18, 8:27 AM

	Unknown Object (File)
	Jan 12 2025, 1:38 AM

	Unknown Object (File)
	Dec 24 2024, 6:00 PM

	Unknown Object (File)
	Dec 20 2024, 3:29 AM

	Unknown Object (File)
	Dec 13 2024, 6:02 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP122f643d6f36: Fix two issues where StandardPageView assumes it will always have access to a…

Summary

If we hit an exception very early, the request may not have a user yet. Don't assume it will.

Test Plan

Broke MySQL config on purpose to test some stuff, loaded Phabricator, got a nice error page instead of a super-fatal one.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Oct 11 2013, 10:25 PM

Closed by commit rP122f643d6f36 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

view/

page/

PhabricatorStandardPageView.php

10 lines

Diff 16419

View Options

src/view/page/PhabricatorStandardPageView.php

Fix two issues where StandardPageView assumes it will always have access to a userClosedPublicActions