Differential D7285

Make the policy control a JS dropdown with icons
ClosedPublic
Actions

Authored by epriestley on Oct 11 2013, 2:22 AM.

Tags

None

Referenced Files

	F15759774: D7285.id16417.diff
	Fri, May 30, 3:30 AM

	Unknown Object (File)
	Wed, May 28, 12:11 PM

	Unknown Object (File)
	Tue, May 27, 4:10 AM

	Unknown Object (File)
	Thu, May 8, 2:24 AM

	Unknown Object (File)
	Tue, May 6, 9:09 PM

	Unknown Object (File)
	Apr 28 2025, 7:49 AM

	Unknown Object (File)
	Apr 27 2025, 5:40 AM

	Unknown Object (File)
	Apr 26 2025, 3:24 AM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T603: Support permissions/policies in all Phabricator applications

Commits

Restricted Diffusion Commit
rP5af031ec9bcb: Make the policy control a JS dropdown with icons

Summary

Ref T603. After thinking about this for a bit I can't really come up with anything better than what Facebook does, so I'm going to implement something similar for choosing custom policies. To start with, swap this over to a JS-driven dropdown.

Test Plan

See screenshot.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

{F67263}

I like it, the only issue is when you have a redonk number of projects. At some point maybe has 'See All...' as the last option and generate a dialog?

Yeah, I'm going to collapse that to your like 5 "favorites" with a "more...", for some definition of "favorites" that I haven't decided on yet.

Probably "most recently used" because anything else would be even more of a pain to derive and record, and I don't think I can get away with "alphabetically first" without users complaining.

If a project has even been used to manage a policy (or is type policy).

Maybe it should be "alphabetically first", and then we can just tell users to pick names like "AAAAA Design" for their favorite projects.

Can you Flag a project?

@chad - you can't currently flag a project. implementing it would be easy enough

code looks good to me. maybs suggestion inline.

webroot/rsrc/js/application/policy/behavior-policy-control.js
16	maybe have this come in from PHP (config.menuWidth) land?

Closed by commit rP5af031ec9bcb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__celerity_resource_map__.php

190 lines

applications/

policy/

constants/

PhabricatorPolicyType.php

4 lines

view/

form/

control/

AphrontFormPolicyControl.php

89 lines

webroot/

rsrc/

css/

phui/

phui-button.css

22 lines

js/

application/

policy/

behavior-policy-control.js

50 lines

core/

DropdownMenu.js

30 lines

Diff 16417

src/__celerity_resource_map__.php

Loading...

src/applications/policy/constants/PhabricatorPolicyType.php

Loading...

src/view/form/control/AphrontFormPolicyControl.php

Loading...

webroot/rsrc/css/phui/phui-button.css

Loading...

webroot/rsrc/js/application/policy/behavior-policy-control.js

Loading...

webroot/rsrc/js/core/DropdownMenu.js

Loading...