Page MenuHomePhabricator

Add Subscribe capability to hovercard view
Changes PlannedPublic

Authored by AnhNhan on Apr 7 2013, 4:25 PM.
Tags
None
Referenced Files
F11527988: D5613.diff
Sat, Feb 4, 5:06 PM
Unknown Object (File)
Mon, Jan 30, 3:02 PM
Unknown Object (File)
Jan 2 2023, 5:33 PM
Unknown Object (File)
Dec 24 2022, 9:27 PM
Unknown Object (File)
Dec 2 2022, 1:48 PM
Unknown Object (File)
Dec 2 2022, 1:47 PM
Unknown Object (File)
Dec 2 2022, 1:47 PM
Unknown Object (File)
Nov 17 2022, 4:52 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
Restricted Maniphest Task
Summary

Refs T1048 - Subscriptions action added to hovercard by event listener - not for Differential & Maniphest though

Also adds form option to actions

Test Plan

Clicked that button for Pholio Mocks, got subscribed/unsubscribed. Workflow does not work D: (you get a page reload basically)

Diff Detail

Repository
rP Phabricator
Branch
D5613-2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 627
Build 627: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
108

Would probably prefer to have this be 'Subscribed' but have the button inactive, like the action list on the object.

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
108

Oh, thanks for spotting. This wasn't supposed to be here.

Just kicking this back for @chad's comments.

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
100–105

I think this one can go either way, but in general we should err on the side of showing (but disabling/deactivating) options which are possible but not currently permitted -- this lets the user click them to learn why they can't take the action. But just dropping the button in this case seems pretty reasonable.

src/view/widget/hovercard/PhabricatorHovercardView.php
44–52

Maybe this should just be a PhabricatorActionView? Not sure how messy that would be. Would simplify the disabled/inactive stuff too.

AnhNhan edited edge metadata.

Updating this diff, rebasing to latest master. You guys have been very busy.

I'll go for using the action view in hover cards, coming in another diff (soonish).

chad retitled this revision from Adding "CC" capability to hovercard view to Add Subscribe capability to hovercard view.Jun 15 2016, 8:39 PM
chad edited edge metadata.
chad changed the visibility from "All Users" to "Public (No Login Required)".

Oh, this would actually be pretty cool.