Page MenuHomePhabricator

Tokens v1
ClosedPublic

Authored by epriestley on Feb 14 2013, 11:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 6:37 PM
Unknown Object (File)
Sat, Jan 11, 5:47 AM
Unknown Object (File)
Dec 27 2024, 2:26 PM
Unknown Object (File)
Dec 15 2024, 4:24 PM
Unknown Object (File)
Dec 12 2024, 10:41 AM
Unknown Object (File)
Dec 8 2024, 8:27 PM
Unknown Object (File)
Dec 8 2024, 8:27 PM
Unknown Object (File)
Dec 8 2024, 8:27 PM
Subscribers

Details

Reviewers
vrana
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP49c40d209dd1: Tokens v1
Summary

Features!

  • Giving tokens.
  • Taking tokens back.
  • Not giving tokens.
Test Plan

See screenshots.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/tokens/controller/PhabricatorTokenGiveController.php
39

hi

Only Pholio and Differential are implemented for now; the others are easy but I figured I wouldn't go too crazy just yet. In both applications, a link appears to "Give Token" if the Token app is installed:

{F32815}

Clicking it allows you to choose a token to give:

{F32817}

If an object has at least one token, tokens are shown. If you've given a token, the option changes to "Rescind Token", like "Unlike". You can change a token by rescinding it and then giving a different one, if you want:

{F32819}

Hovering over a token shows who gave it:

{F32821}

The application part shows all tokens given to things:

{F32823}

Notable stuff missing in this version:

  • We don't notify the object owner that they got a token (this seems very important and probably needs to be in v1.1).
  • We have data in the database to show a "most liked objects ever" view, but don't currently.
  • We have data to support more flexible browsing ("all tokens given by user X", "all tokens of type Y given") but no UI.
  • We don't have a UI list of tokens other than the dialog itself.
  • No adding new custom tokens yet.
  • If an object has a million tokens, we'll just show them all. We have the data to show the most recent N and link to "(1,000,000 total...)" but don't currently do that.
epriestley updated this revision to Unknown Object (????).Feb 14 2013, 11:45 PM
  • Remove phlog().
  • Remove unused controller.

(We also need more app integrations, obviously, but that's pretty straightforward.)

I'd probably just add them to tasks now as well. Between this and CC's I think we can really naturally derive the importance of a task to the community.

epriestley updated this revision to Unknown Object (????).Feb 15 2013, 12:13 AM
  • Maniphest support.

What are your thoughts on 'Give Tokens'... anything more clever or fun we can use there... 'Emojify?' etc...

Whelp, @vrana and @btrahan are gone. Let's ship some shit!

Hahaha, this is a good one. :)

chad changed the visibility from "All Users" to "Public (No Login Required)".
chad edited edge metadata.

oh man that UI is old.