Page MenuHomePhabricator

Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways
ClosedPublic

Authored by epriestley on May 3 2022, 6:10 PM.
Tags
None
Referenced Files
F13202148: D21795.diff
Tue, May 14, 10:19 PM
F13201344: D21795.diff
Tue, May 14, 11:03 AM
F13198270: D21795.diff
Mon, May 13, 5:31 AM
F13183317: D21795.diff
Fri, May 10, 8:18 AM
F13180785: D21795.id51951.diff
Thu, May 9, 3:55 AM
Unknown Object (File)
Mon, May 6, 6:32 AM
Unknown Object (File)
Sat, May 4, 6:14 PM
Unknown Object (File)
Sat, May 4, 11:19 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. Ref T13588. Fix some issues that prevent "bin/phd" and "bin/drydock" from executing under PHP 8.1, broadly because null is being passed to strlen().

Test Plan

Ran bin/phd debug task and bin/drydock ... under PHP 8.1.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 3 2022, 6:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM
This revision was automatically updated to reflect the committed changes.