Page MenuHomePhabricator

Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways
ClosedPublic

Authored by epriestley on May 3 2022, 6:10 PM.
Tags
None
Referenced Files
F18264138: D21795.diff
Fri, Aug 22, 10:25 AM
F18234185: D21795.id.diff
Wed, Aug 20, 5:38 PM
F18219428: D21795.diff
Tue, Aug 19, 11:35 AM
F18203762: D21795.diff
Mon, Aug 18, 12:47 PM
F18106677: D21795.id.diff
Sun, Aug 10, 11:12 PM
F18078507: D21795.diff
Mon, Aug 4, 8:10 PM
F18052316: D21795.diff
Mon, Aug 4, 2:06 AM
F18044097: D21795.diff
Sun, Aug 3, 6:47 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. Ref T13588. Fix some issues that prevent "bin/phd" and "bin/drydock" from executing under PHP 8.1, broadly because null is being passed to strlen().

Test Plan

Ran bin/phd debug task and bin/drydock ... under PHP 8.1.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.May 3 2022, 6:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM
This revision was automatically updated to reflect the committed changes.