Page MenuHomePhabricator

Correct an issue when winning "arc anoid" with certain terminal dimensions
ClosedPublic

Authored by epriestley on Tue, Jun 1, 6:07 AM.

Details

Summary

See PHI2085. Python 3 is stricter about integers and floats than Python 2 was, and we can end up passing a float where an integer was expected if the player wins "arc anoid" using a terminal with certain (most?) character dimensions.

Test Plan
  • Modified "arcanoid.py" to win instantly.
  • Adjusted terminal window to 80x24, ran "arc anoid", reproduced crash.
  • Ran "python2 arcanoid.py" and observed old victory animation behavior.
  • Applied patch.
  • Ran "arc anoid" and observed identical victory animation behavior.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from Correct an issue when winning "arc anoid" with an odd terminal width to Correct an issue when winning "arc anoid" with certain terminal widths.Tue, Jun 1, 6:10 AM
epriestley edited the summary of this revision. (Show Details)
epriestley edited the test plan for this revision. (Show Details)
epriestley retitled this revision from Correct an issue when winning "arc anoid" with certain terminal widths to Correct an issue when winning "arc anoid" with certain terminal dimensions.
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jun 1, 6:10 AM
This revision was automatically updated to reflect the committed changes.