Page MenuHomePhabricator

Add a lint check for catching "Exception" without catching "Throwable"
ClosedPublic

Authored by epriestley on Feb 3 2021, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 7:56 PM
Unknown Object (File)
Fri, Feb 7, 6:28 AM
Unknown Object (File)
Fri, Jan 31, 8:27 PM
Unknown Object (File)
Thu, Jan 23, 12:51 AM
Unknown Object (File)
Tue, Jan 21, 3:59 PM
Unknown Object (File)
Tue, Jan 21, 10:02 AM
Unknown Object (File)
Jan 9 2025, 5:22 AM
Unknown Object (File)
Dec 31 2024, 5:02 PM
Subscribers
None

Details

Summary

Ref T13588. For consistency of behavior between versions on either side of PHP7, any "catch (Exception)" block should generally have a "catch (Throwable)" block in the same catch list.

Raise a lint warning when "Exception" is caught without also catching "Throwable", since this is almost certainly not desired.

Test Plan

Added tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable