Page MenuHomePhabricator

Allow "differential.createinline" to accept JSON "false" for "isNewFile"
ClosedPublic

Authored by epriestley on Jan 26 2021, 10:48 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/error-creating-inline-comment-via-conduit-api/4535. See T12678.

This API method currently does not accept a JSON "false", but reasonably should.

Test Plan
  • Called method with "isNewFile: false".
    • Before: type error.
    • After: inline comment.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2021, 10:56 PM
This revision was automatically updated to reflect the committed changes.