Page MenuHomePhabricator

In "phutil_passthru()", "resolve()" the future rather than calling "execute()" directly
ClosedPublic

Authored by epriestley on Sep 18 2020, 6:22 PM.

Details

Summary

See PHI1862. This code calls "execute()" on the future directly, but that skips some steps -- notably, ServiceProfiler hooks.

Call "resolve()", which has the same effect but includes desirable/expected side effects.

Test Plan

Changed a workflow to run "phutil_passthru('ls')", ran it with "--trace". Before: no execution in trace; after: execution in trace.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.