Differential D21451

When printing timestamps on paper: use an absolute, context-free date format
ClosedPublic
Actions

Authored by epriestley on Sep 4 2020, 11:25 PM.

Tags

None

Referenced Files

	F15416809: D21451.id51052.diff
	Thu, Mar 20, 1:40 PM

	F15404720: D21451.id51052.diff
	Tue, Mar 18, 8:44 AM

	F15393441: D21451.id51052.diff
	Sat, Mar 15, 8:57 PM

	F15380910: D21451.id51051.diff
	Fri, Mar 14, 4:57 AM

	F15338883: D21451.id51052.diff
	Sun, Mar 9, 1:19 PM

	F15334397: D21451.diff
	Sat, Mar 8, 8:46 AM

	F15332992: D21451.id51053.diff
	Fri, Mar 7, 10:56 PM

	F15282928: D21451.id51052.diff
	Tue, Mar 4, 3:42 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13573: When printing, render dates in an absolute, context-free format
Commits: rP69662a11d73d: (stable) When printing timestamps on paper: use an absolute, context-free date…
rP0854425d191f: When printing timestamps on paper: use an absolute, context-free date format

Summary

Ref T13573. Using the browser "Print" feature on pages produces "Thu, Aug 4, 12:22" timestamps which require context to interpret precisely (they don't have a year and don't have a timezone).

Instead, retain these timestamps in "screen" contexts but use "YYYY-MM-DD HH:MM:SS (UTC+X)" timestamps when printing.

Test Plan

Printed Maniphest tasks and other pages in Safari and Chrome using "?print=1" and "Print to PDF", saw absolute timestamps after this chagne in the printed documents.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 4 2020, 11:25 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 4 2020, 11:27 PM

Harbormaster failed remote builds in B24866: Diff 51051!

Update library map.

Harbormaster completed remote builds in B24867: Diff 51052.Sep 4 2020, 11:33 PM

epriestley requested review of this revision.Sep 4 2020, 11:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 4 2020, 11:36 PM

Closed by commit rP0854425d191f: When printing timestamps on paper: use an absolute, context-free date format (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0854425d191f: When printing timestamps on paper: use an absolute, context-free date format.

epriestley added a commit: rP69662a11d73d: (stable) When printing timestamps on paper: use an absolute, context-free date….Sep 4 2020, 11:44 PM

epriestley mentioned this in T13573: When printing, render dates in an absolute, context-free format.Apr 20 2022, 7:18 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

__phutil_library_map__.php

applications/

phriction/

controller/

PhrictionDocumentController.php

2 lines

infrastructure/

javelin/

17 lines

view/

phui/

PHUICurtainObjectRefView.php

2 lines

PHUIObjectItemView.php

2 lines

PHUITimelineEventView.php

3 lines

33 lines

webroot/

rsrc/

css/

core/

27 lines

Diff 51053

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...

src/infrastructure/javelin/markup.php

Loading...

src/view/phui/PHUICurtainObjectRefView.php

Loading...

src/view/phui/PHUIObjectItemView.php

Loading...

src/view/phui/PHUITimelineEventView.php

Loading...

src/view/viewutils.php

Loading...

webroot/rsrc/css/core/core.css

Loading...