Page MenuHomePhabricator

Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
ClosedPublic

Authored by epriestley on May 7 2020, 8:59 PM.
Tags
None
Referenced Files
F15464132: D21234.diff
Wed, Apr 2, 6:39 AM
F15461081: D21234.id50560.diff
Tue, Apr 1, 5:03 AM
F15454974: D21234.id.diff
Sat, Mar 29, 9:40 PM
F15449463: D21234.diff
Fri, Mar 28, 10:27 AM
F15439821: D21234.id50570.diff
Wed, Mar 26, 9:38 AM
F15413637: D21234.diff
Wed, Mar 19, 8:16 PM
F15381515: D21234.diff
Fri, Mar 14, 8:01 AM
F15344241: D21234.id50559.diff
Mon, Mar 10, 3:19 AM
Subscribers
None

Details

Summary

Ref T13513. All queries now go through a reasonably minimal set of pathways and should have consistent behavior.

Test Plan
  • Loaded a revision with inlines.
  • Created a new empty inline, reloaded page, saw it vanish.
  • Created a new empty inline, typed draft text, did not save, reloaded page, saw draft present.
  • Created a new empty inline, typed draft text. Submitted feedback, got prompt, answered "Y", saw draft text submit.
  • Created a new empty inline, typed draft text, scrolled down to bottom of page, typed non-draft text, saw preview include draft text.
  • Marked and submitted "Done".
  • Used hide/show on inlines, verified state persisted.
  • Did much of the same stuff in Diffusion, where it all works the same way (except: there's no prompt when submitting draft is-editing inlines).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley edited the test plan for this revision. (Show Details)
  • Fix a couple issues caught during testing.
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:11 PM
This revision was automatically updated to reflect the committed changes.