Page MenuHomePhabricator

Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
ClosedPublic

Authored by epriestley on May 7 2020, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 6:07 AM
Unknown Object (File)
Jan 22 2024, 11:10 PM
Unknown Object (File)
Jan 11 2024, 12:03 PM
Unknown Object (File)
Jan 6 2024, 8:37 PM
Unknown Object (File)
Jan 5 2024, 1:23 PM
Unknown Object (File)
Dec 29 2023, 4:57 PM
Unknown Object (File)
Dec 25 2023, 7:39 AM
Unknown Object (File)
Dec 25 2023, 3:28 AM
Subscribers
None

Details

Summary

Ref T13513. All queries now go through a reasonably minimal set of pathways and should have consistent behavior.

Test Plan
  • Loaded a revision with inlines.
  • Created a new empty inline, reloaded page, saw it vanish.
  • Created a new empty inline, typed draft text, did not save, reloaded page, saw draft present.
  • Created a new empty inline, typed draft text. Submitted feedback, got prompt, answered "Y", saw draft text submit.
  • Created a new empty inline, typed draft text, scrolled down to bottom of page, typed non-draft text, saw preview include draft text.
  • Marked and submitted "Done".
  • Used hide/show on inlines, verified state persisted.
  • Did much of the same stuff in Diffusion, where it all works the same way (except: there's no prompt when submitting draft is-editing inlines).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley edited the test plan for this revision. (Show Details)
  • Fix a couple issues caught during testing.
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:11 PM
This revision was automatically updated to reflect the committed changes.