Page MenuHomePhabricator

Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
ClosedPublic

Authored by epriestley on Thu, May 7, 8:59 PM.

Details

Summary

Ref T13513. All queries now go through a reasonably minimal set of pathways and should have consistent behavior.

Test Plan
  • Loaded a revision with inlines.
  • Created a new empty inline, reloaded page, saw it vanish.
  • Created a new empty inline, typed draft text, did not save, reloaded page, saw draft present.
  • Created a new empty inline, typed draft text. Submitted feedback, got prompt, answered "Y", saw draft text submit.
  • Created a new empty inline, typed draft text, scrolled down to bottom of page, typed non-draft text, saw preview include draft text.
  • Marked and submitted "Done".
  • Used hide/show on inlines, verified state persisted.
  • Did much of the same stuff in Diffusion, where it all works the same way (except: there's no prompt when submitting draft is-editing inlines).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 7, 8:59 PM
epriestley requested review of this revision.Thu, May 7, 9:01 PM
epriestley updated this revision to Diff 50560.Thu, May 7, 10:51 PM
epriestley edited the test plan for this revision. (Show Details)
  • Fix a couple issues caught during testing.
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 7, 11:11 PM
This revision was automatically updated to reflect the committed changes.