Page MenuHomePhabricator

Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
ClosedPublic

Authored by epriestley on May 7 2020, 8:59 PM.
Tags
None
Referenced Files
F20611573: D21234.diff
Sat, Jun 20, 8:12 AM
Unknown Object (File)
Apr 1 2026, 2:02 AM
Unknown Object (File)
Mar 29 2026, 1:57 PM
Unknown Object (File)
Mar 28 2026, 3:51 PM
Unknown Object (File)
Mar 4 2026, 10:08 AM
Unknown Object (File)
Mar 4 2026, 1:09 AM
Unknown Object (File)
Mar 2 2026, 8:31 AM
Unknown Object (File)
Feb 3 2026, 9:54 PM
Subscribers
None

Details

Summary

Ref T13513. All queries now go through a reasonably minimal set of pathways and should have consistent behavior.

Test Plan
  • Loaded a revision with inlines.
  • Created a new empty inline, reloaded page, saw it vanish.
  • Created a new empty inline, typed draft text, did not save, reloaded page, saw draft present.
  • Created a new empty inline, typed draft text. Submitted feedback, got prompt, answered "Y", saw draft text submit.
  • Created a new empty inline, typed draft text, scrolled down to bottom of page, typed non-draft text, saw preview include draft text.
  • Marked and submitted "Done".
  • Used hide/show on inlines, verified state persisted.
  • Did much of the same stuff in Diffusion, where it all works the same way (except: there's no prompt when submitting draft is-editing inlines).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley edited the test plan for this revision. (Show Details)
  • Fix a couple issues caught during testing.
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:11 PM
This revision was automatically updated to reflect the committed changes.