Page MenuHomePhabricator
Differential D21233

Remove "DifferentialInlineCommentQuery"
ClosedPublic
Actions

Authored by epriestley on May 7 2020, 8:31 PM.
Tags
None
Referenced Files
F15471965: D21233.diff
Sat, Apr 5, 10:10 AM
F15470327: D21233.id50569.diff
Fri, Apr 4, 9:34 PM
F15457169: D21233.id50558.diff
Sun, Mar 30, 2:43 PM
F15450270: D21233.id.diff
Fri, Mar 28, 2:48 PM
F15448757: D21233.diff
Fri, Mar 28, 6:45 AM
F15433556: D21233.id50569.diff
Mon, Mar 24, 11:46 PM
F15414230: D21233.diff
Wed, Mar 19, 11:34 PM
F15409487: D21233.id50569.diff
Wed, Mar 19, 4:35 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP79107574a762: Remove "DifferentialInlineCommentQuery"
Summary

Ref T13513. Replaces "DifferentialInlineCommentQuery" with the similar but more modern "DifferentialDiffInlineCommentQuery".

Test Plan

Viewed comments in timeline, changesets. Created, edited, and submitted comments. Hid and un-hid comments, reloading (saw state preserved).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 7 2020, 8:31 PM
Harbormaster completed remote builds in B24374: Diff 50558.May 7 2020, 8:33 PM
epriestley requested review of this revision.May 7 2020, 8:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:08 PM
Closed by commit rP79107574a762: Remove "DifferentialInlineCommentQuery" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP79107574a762: Remove "DifferentialInlineCommentQuery".

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
23 lines
22 lines
engine/
22 lines
query/
22 lines
diffusion/
query/
6 lines
infrastructure/
diff/
engine/
applications/
differential/
query/
PhabricatorInlineCommentAdjustmentEngine.php
DifferentialInlineCommentQuery.php
171 lines
infrastructure/
diff/
query/
38 lines

Diff 50569

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/engine/DifferentialRevisionTimelineEngine.php

Loading...
View Options

src/applications/differential/query/DifferentialDiffInlineCommentQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialInlineCommentQuery.php

Loading...
View Options

src/applications/diffusion/query/DiffusionDiffInlineCommentQuery.php

Loading...
View Options

src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php

Loading...
View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

Loading...
Phabricator · Built by Phacility