Page MenuHomePhabricator

Replace "loadDraftAndPublishedComments()" with a Query
ClosedPublic

Authored by epriestley on May 7 2020, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 10 2024, 10:09 AM
Unknown Object (File)
Jan 10 2024, 2:47 AM
Unknown Object (File)
Jan 9 2024, 8:11 AM
Unknown Object (File)
Jan 5 2024, 1:24 PM
Unknown Object (File)
Dec 30 2023, 9:11 AM
Unknown Object (File)
Dec 30 2023, 2:22 AM
Unknown Object (File)
Dec 29 2023, 7:39 PM
Unknown Object (File)
Dec 24 2023, 4:02 PM
Subscribers
None

Details

Summary

Ref T13513. Continue marching toward coherent query pathways for all access to inline comments.

Test Plan
  • Viewed a commit and a path within that commit, as a user with unpublished inlines and a different user.
  • Saw appropriate inlines in all cases (published inlines, plus undeleted unpublished inlines authored by the current viewer).
  • Grepped for "loadDraftAndPublishedComments()".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:02 PM
This revision was automatically updated to reflect the committed changes.