Differential D21228

Replace "loadDraftAndPublishedComments()" with a Query
ClosedPublic
Actions

Authored by epriestley on May 7 2020, 6:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 9:14 AM

	Unknown Object (File)
	Sun, Feb 9, 9:14 AM

	Unknown Object (File)
	Sun, Feb 9, 9:14 AM

	Unknown Object (File)
	Sun, Feb 9, 9:14 AM

	Unknown Object (File)
	Sat, Jan 25, 1:02 PM

	Unknown Object (File)
	Sat, Jan 25, 7:34 AM

	Unknown Object (File)
	Sat, Jan 25, 7:34 AM

	Unknown Object (File)
	Sat, Jan 25, 7:34 AM

View All 94 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13513: Make schema changes to inlines to prepare for new inline features
Commits: rPd0593a5a788e: Replace "loadDraftAndPublishedComments()" with a Query

Summary

Ref T13513. Continue marching toward coherent query pathways for all access to inline comments.

Test Plan

Viewed a commit and a path within that commit, as a user with unpublished inlines and a different user.
Saw appropriate inlines in all cases (published inlines, plus undeleted unpublished inlines authored by the current viewer).
Grepped for "loadDraftAndPublishedComments()".

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 7 2020, 6:56 PM

Harbormaster completed remote builds in B24369: Diff 50553.May 7 2020, 6:57 PM

epriestley requested review of this revision.May 7 2020, 6:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:02 PM

Closed by commit rPd0593a5a788e: Replace "loadDraftAndPublishedComments()" with a Query (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd0593a5a788e: Replace "loadDraftAndPublishedComments()" with a Query.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

storage/

PhabricatorAuditInlineComment.php

23 lines

diffusion/

controller/

DiffusionCommitController.php

11 lines

DiffusionDiffController.php

11 lines

infrastructure/

diff/

query/

PhabricatorDiffInlineCommentQuery.php

78 lines

Diff 50564

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...

src/applications/diffusion/controller/DiffusionDiffController.php

Loading...

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

Loading...