Page MenuHomePhabricator

Replace "loadDraftAndPublishedComments()" with a Query
ClosedPublic

Authored by epriestley on May 7 2020, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 5 2025, 4:54 PM
Unknown Object (File)
May 8 2025, 1:04 AM
Unknown Object (File)
Apr 29 2025, 4:47 PM
Unknown Object (File)
Apr 12 2025, 11:46 AM
Unknown Object (File)
Apr 9 2025, 1:10 AM
Unknown Object (File)
Apr 3 2025, 1:47 PM
Unknown Object (File)
Apr 2 2025, 6:39 AM
Unknown Object (File)
Mar 31 2025, 6:52 PM
Subscribers
None

Details

Summary

Ref T13513. Continue marching toward coherent query pathways for all access to inline comments.

Test Plan
  • Viewed a commit and a path within that commit, as a user with unpublished inlines and a different user.
  • Saw appropriate inlines in all cases (published inlines, plus undeleted unpublished inlines authored by the current viewer).
  • Grepped for "loadDraftAndPublishedComments()".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:02 PM
This revision was automatically updated to reflect the committed changes.