Page MenuHomePhabricator

Replace "loadDraftAndPublishedComments()" with a Query
ClosedPublic

Authored by epriestley on May 7 2020, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 11:04 AM
Unknown Object (File)
Dec 11 2024, 2:00 PM
Unknown Object (File)
Dec 9 2024, 11:56 AM
Unknown Object (File)
Dec 1 2024, 5:33 AM
Unknown Object (File)
Nov 26 2024, 11:39 PM
Unknown Object (File)
Nov 23 2024, 4:19 PM
Unknown Object (File)
Nov 18 2024, 5:11 PM
Unknown Object (File)
Nov 14 2024, 7:46 PM
Subscribers
None

Details

Summary

Ref T13513. Continue marching toward coherent query pathways for all access to inline comments.

Test Plan
  • Viewed a commit and a path within that commit, as a user with unpublished inlines and a different user.
  • Saw appropriate inlines in all cases (published inlines, plus undeleted unpublished inlines authored by the current viewer).
  • Grepped for "loadDraftAndPublishedComments()".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2020, 11:02 PM
This revision was automatically updated to reflect the committed changes.