Page MenuHomePhabricator

Replace "loadDraftAndPublishedComments()" with a Query
ClosedPublic

Authored by epriestley on Thu, May 7, 6:56 PM.

Details

Summary

Ref T13513. Continue marching toward coherent query pathways for all access to inline comments.

Test Plan
  • Viewed a commit and a path within that commit, as a user with unpublished inlines and a different user.
  • Saw appropriate inlines in all cases (published inlines, plus undeleted unpublished inlines authored by the current viewer).
  • Grepped for "loadDraftAndPublishedComments()".

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, May 7, 6:56 PM
epriestley requested review of this revision.Thu, May 7, 6:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 7, 11:02 PM
This revision was automatically updated to reflect the committed changes.