Page MenuHomePhabricator

When cancelling an unsaved editing inline after a reload, don't cancel into an empty state
ClosedPublic

Authored by epriestley on May 4 2020, 9:01 PM.

Details

Summary

Ref T13513. Overloading "original text" to get "edit-on-load" comments into the right state has some undesirable side effects.

Instead, provide the text when the editor opens. This fixes a cancel interaction.

Test Plan
  • Create an inline, type text, don't save.
  • Reload page.
  • Cancel.
  • Before: cancelled into empty state.
  • After: cancelled into deleted+undo state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 10:20 PM
This revision was automatically updated to reflect the committed changes.