Page MenuHomePhabricator

When cancelling an unsaved editing inline after a reload, don't cancel into an empty state
ClosedPublic

Authored by epriestley on Mon, May 4, 9:01 PM.

Details

Summary

Ref T13513. Overloading "original text" to get "edit-on-load" comments into the right state has some undesirable side effects.

Instead, provide the text when the editor opens. This fixes a cancel interaction.

Test Plan
  • Create an inline, type text, don't save.
  • Reload page.
  • Cancel.
  • Before: cancelled into empty state.
  • After: cancelled into deleted+undo state.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 9:01 PM
epriestley requested review of this revision.Mon, May 4, 9:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 10:20 PM
This revision was automatically updated to reflect the committed changes.