Page MenuHomePhabricator

When rendering changesets, discard empty draft inline comments
ClosedPublic

Authored by epriestley on May 4 2020, 5:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 6:24 AM
Unknown Object (File)
Mon, Dec 16, 5:52 AM
Unknown Object (File)
Mon, Dec 16, 5:52 AM
Unknown Object (File)
Mon, Dec 16, 5:52 AM
Unknown Object (File)
Fri, Dec 13, 3:41 AM
Unknown Object (File)
Thu, Dec 12, 9:54 AM
Unknown Object (File)
Tue, Dec 10, 9:31 PM
Unknown Object (File)
Mon, Dec 9, 1:29 PM
Subscribers
None

Details

Summary

Ref T13513. When you load a changeset, discard all empty inlines. This is likely a more desirable behavior than keeping empty editors around, even though the rest of the pipeline generally handles them fairly well now.

Test Plan
  • Started an inline, didn't type any text or save, reloaded page.
    • Before: page restores empty editor in the same place.
    • After: we just discard this likely-pointless empty inline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:16 PM
This revision was automatically updated to reflect the committed changes.