Page MenuHomePhabricator

When rendering changesets, discard empty draft inline comments
ClosedPublic

Authored by epriestley on May 4 2020, 5:18 PM.
Tags
None
Referenced Files
F18769720: D21214.diff
Wed, Oct 8, 8:50 AM
F18764349: D21214.id50527.diff
Tue, Oct 7, 5:33 AM
F18606721: D21214.id50527.diff
Sep 13 2025, 10:32 PM
F18184872: D21214.id50527.diff
Aug 16 2025, 2:27 PM
F18112311: D21214.diff
Aug 12 2025, 4:21 PM
F18101080: D21214.id.diff
Aug 9 2025, 12:19 PM
F18088904: D21214.id50517.diff
Aug 6 2025, 10:00 AM
F18073548: D21214.id.diff
Aug 4 2025, 5:22 PM
Subscribers
None

Details

Summary

Ref T13513. When you load a changeset, discard all empty inlines. This is likely a more desirable behavior than keeping empty editors around, even though the rest of the pipeline generally handles them fairly well now.

Test Plan
  • Started an inline, didn't type any text or save, reloaded page.
    • Before: page restores empty editor in the same place.
    • After: we just discard this likely-pointless empty inline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:16 PM
This revision was automatically updated to reflect the committed changes.