Page MenuHomePhabricator

When rendering changesets, discard empty draft inline comments
ClosedPublic

Authored by epriestley on May 4 2020, 5:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 5, 4:53 PM
Unknown Object (File)
Tue, Jun 3, 2:28 PM
Unknown Object (File)
Mon, Jun 2, 9:01 AM
Unknown Object (File)
Sat, May 31, 12:59 PM
Unknown Object (File)
May 5 2025, 9:18 PM
Unknown Object (File)
Apr 30 2025, 1:15 PM
Unknown Object (File)
Apr 28 2025, 1:36 AM
Unknown Object (File)
Apr 27 2025, 12:12 AM
Subscribers
None

Details

Summary

Ref T13513. When you load a changeset, discard all empty inlines. This is likely a more desirable behavior than keeping empty editors around, even though the rest of the pipeline generally handles them fairly well now.

Test Plan
  • Started an inline, didn't type any text or save, reloaded page.
    • Before: page restores empty editor in the same place.
    • After: we just discard this likely-pointless empty inline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:16 PM
This revision was automatically updated to reflect the committed changes.