Page MenuHomePhabricator

Accommodate PHP 7.4 changes to certain "preg_match_all()" calls
ClosedPublic

Authored by epriestley on Apr 26 2020, 3:32 PM.

Details

Summary

Ref T13518. The result format of this call changed in PHP 7.4, which causes us to emit "-1" matches because "-1" survives array_filter().

Filter results in a way that should survive both result formats.

Test Plan

Ran arc unit --everything under PHP 7.4.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 26 2020, 3:32 PM
Harbormaster failed remote builds in B24233: Diff 50414!
  • Swap order to work better under PHP 7.3 and earlier.
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 26 2020, 3:35 PM
Harbormaster failed remote builds in B24234: Diff 50415!
  • Actually look at the PHP 7.3x output before writing code for it.
  • Third try's the charm!
This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2020, 3:39 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.