Page MenuHomePhabricator

If HTTP response headers are already sent, don't fiddle with "zlib.output_compression"
ClosedPublic

Authored by epriestley on Apr 3 2020, 7:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 5:29 PM
Unknown Object (File)
Thu, Dec 19, 3:55 PM
Unknown Object (File)
Dec 8 2024, 3:27 AM
Unknown Object (File)
Dec 7 2024, 10:53 PM
Unknown Object (File)
Dec 3 2024, 12:26 AM
Unknown Object (File)
Nov 28 2024, 10:02 PM
Unknown Object (File)
Nov 25 2024, 5:44 AM
Unknown Object (File)
Nov 23 2024, 9:50 AM
Subscribers
None

Details

Summary

We write some synthetic HTTP responses inside unit tests. Some responses have an indirect side effect of adjusting "zlib.output_compression", but this adjustment fails if headers have already been output. From a CLI context, headers appear to count as already-output after we write anything to stdout:

<?php

echo headers_sent() ? "Y" : "N";
echo "\n";
echo headers_sent() ? "Y" : "N";
echo "\n";

This script prints "N", then "Y".

Recently, the default severity of warnings was increased in libphutil; this has been a long-standing warning but now causes test failures.

This behavior is sort of silly but the whole thing is kind of moot anyway. Just skip it if "headers_sent()" is true.

Test Plan

Ran "arc unit --everything", got clean results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable