Page MenuHomePhabricator

Add a test to verify that all routing maps are plausibly valid, and remove some dead routes
ClosedPublic

Authored by epriestley on Feb 14 2020, 10:39 PM.
Tags
None
Referenced Files
F17712060: D21000.diff
Thu, Jul 17, 9:23 AM
Unknown Object (File)
Sat, Jun 28, 11:01 AM
Unknown Object (File)
May 20 2025, 10:44 AM
Unknown Object (File)
May 8 2025, 3:24 AM
Unknown Object (File)
Apr 30 2025, 5:36 AM
Unknown Object (File)
Apr 21 2025, 3:26 PM
Unknown Object (File)
Mar 30 2025, 10:38 AM
Unknown Object (File)
Mar 30 2025, 9:20 AM
Subscribers
Restricted Owners Package

Details

Summary

Previously, see D20999. See also https://discourse.phabricator-community.org/t/the-phutil-library-phutil-has-not-been-loaded/3543/.

There are a couple of dead "Config" routes after recent changes. Add test coverage to make sure routes all point somewhere valid, then remove all the dead routes that turned up.

Test Plan

Ran tests, saw failures. Removed dead routes, got clean tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 14 2020, 10:39 PM

Specifically, all of the removed rules point at controllers which no longer exist. Most of these were Preview or Edit controllers which are now handled by EditEngine or some other piece of centralized infrastructure.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2020, 2:06 AM
This revision was automatically updated to reflect the committed changes.