Page MenuHomePhabricator

Add a test to verify that all routing maps are plausibly valid, and remove some dead routes
ClosedPublic

Authored by epriestley on Feb 14 2020, 10:39 PM.

Details

Summary

Previously, see D20999. See also https://discourse.phabricator-community.org/t/the-phutil-library-phutil-has-not-been-loaded/3543/.

There are a couple of dead "Config" routes after recent changes. Add test coverage to make sure routes all point somewhere valid, then remove all the dead routes that turned up.

Test Plan

Ran tests, saw failures. Removed dead routes, got clean tests.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 14 2020, 10:39 PM
Owners added a subscriber: Restricted Owners Package.Feb 14 2020, 10:39 PM
epriestley requested review of this revision.Feb 14 2020, 10:40 PM

Specifically, all of the removed rules point at controllers which no longer exist. Most of these were Preview or Edit controllers which are now handled by EditEngine or some other piece of centralized infrastructure.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2020, 2:06 AM
This revision was automatically updated to reflect the committed changes.